From: Chris Leech <cleech@redhat.com>
To: hanyu001@208suo.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla4xxx: Convert snprintf to scnprintf
Date: Wed, 19 Jul 2023 11:14:25 -0700 [thread overview]
Message-ID: <ZLgoARU6tZP8sMfT@rhel-developer-toolbox-latest> (raw)
In-Reply-To: <4a69897245577acfb2f095501b21cd78@208suo.com>
On Mon, Jul 17, 2023 at 02:18:31PM +0800, hanyu001@208suo.com wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/qla4xxx/ql4_attr.c:200:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:273:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:281:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:303:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:210:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:264:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:312:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:159:9-17: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:256:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:247:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:181:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:190:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:223:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:235:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:173:8-16: WARNING: use scnprintf or
> sprintf
>
> Signed-off-by: ztt <1549089851@qq.com>
These should all be converted to sysfs_emit, and not scnprintf.
Thanks,
- Chris Leech
prev parent reply other threads:[~2023-07-19 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_F14720A15AAC92683C94E88876A876E7FC05@qq.com>
2023-07-17 6:18 ` [PATCH] scsi: qla4xxx: Convert snprintf to scnprintf hanyu001
2023-07-19 18:14 ` Chris Leech [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLgoARU6tZP8sMfT@rhel-developer-toolbox-latest \
--to=cleech@redhat.com \
--cc=hanyu001@208suo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox