From: Igor Pylypiv <ipylypiv@google.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-scsi@vger.kernel.org, jinpu.wang@cloud.ionos.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
changyuanl@google.com, pranavpp@google.com
Subject: Re: [PATCH] scsi: pm80xx: fix error return code in pm8001_pci_probe()
Date: Tue, 25 Jul 2023 12:31:08 -0700 [thread overview]
Message-ID: <ZMAi/F7ycX+NUzY5@google.com> (raw)
In-Reply-To: <20230725125706.566990-1-yangyingliang@huawei.com>
On Tue, Jul 25, 2023 at 08:57:06PM +0800, Yang Yingliang wrote:
> If pm8001_init_sas_add() fails, return error code in pm8001_pci_probe().
>
> Fixes: 14a8f116cdc0 ("scsi: pm80xx: Add GET_NVMD timeout during probe")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Igor Pylypiv <ipylypiv@google.com>
> ---
> drivers/scsi/pm8001/pm8001_init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 2e886c1d867d..4995e1ef4e0e 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -1181,7 +1181,8 @@ static int pm8001_pci_probe(struct pci_dev *pdev,
> pm80xx_set_thermal_config(pm8001_ha);
> }
>
> - if (pm8001_init_sas_add(pm8001_ha))
> + rc = pm8001_init_sas_add(pm8001_ha);
> + if (rc)
> goto err_out_shost;
> /* phy setting support for motherboard controller */
> rc = pm8001_configure_phy_settings(pm8001_ha);
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-07-25 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 12:57 [PATCH] scsi: pm80xx: fix error return code in pm8001_pci_probe() Yang Yingliang
2023-07-25 19:31 ` Igor Pylypiv [this message]
2023-07-26 2:03 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMAi/F7ycX+NUzY5@google.com \
--to=ipylypiv@google.com \
--cc=changyuanl@google.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pranavpp@google.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox