Re: [EXT] Re: [PATCH] cnic: change __GFP_COMP allocation method

John Meneghini
2023-12-21T14:33:49Z

Including Greg.

On 12/21/23 01:48, Christoph Hellwig wrote:
> On Tue, Dec 19, 2023 at 06:16:38AM +0000, Nilesh Javali wrote:
>> If you are referring to the series proposed by Chris Leech, then this had
>> objections. And that was the reason to look for an alternative method for
>> coherent DMA mapping.
>>
>> [PATCH 0/3] UIO_MEM_DMA_COHERENT for cnic/bnx2/bnx2x
>
> Yes. Well, Greg (rightly) dislikes what the iscsi drivers have been
> doing. But we're stuck supporting them, so I see no way around that.

If this is true then can we reconsider Chris's patches.

Red Hat has multiple enterprise customers who are relying on this driver and we need to keep it running - at least till the end
of RHEL 9. We can try and drop support for bnx2/cnic in RHEL 10 but RHEL 9 is in the middle of its life cycle and a failure to
address this issue is causing many problems as we attempt to keep RHEL 9 current with what's upstream.

Greg, can we please take Chris's patches upstream?

https://lore.kernel.org/netdev/20230929170023.1020032-3-cleech@redhat.com/

/John