From: Christoph Hellwig <hch@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Avri Altman <avri.altman@wdc.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Bean Huo <beanhuo@micron.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions
Date: Tue, 26 Mar 2024 10:22:37 -0700 [thread overview]
Message-ID: <ZgMEXZffmEqyRgVU@infradead.org> (raw)
In-Reply-To: <7d3a83b5-6dc7-40d2-8a2e-bd5157a3f8ea@acm.org>
On Tue, Mar 26, 2024 at 10:20:13AM -0700, Bart Van Assche wrote:
> On 3/26/24 01:32, Avri Altman wrote:
> > @@ -992,10 +976,6 @@ EXPORT_SYMBOL_GPL(ufshcd_is_hba_active);
> > u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba)
> > {
> > - /* HCI version 1.0 and 1.1 supports UniPro 1.41 */
> > - if (hba->ufs_version <= ufshci_version(1, 1))
> > - return UFS_UNIPRO_VER_1_41;
> > - else
> > return UFS_UNIPRO_VER_1_6;
> > }
>
> Please fix the indentation of the only remaining return statement in
> this function.
Even better just remove the function and use UFS_UNIPRO_VER_1_6
directly in the two callers.
next prev parent reply other threads:[~2024-03-26 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 8:32 [PATCH 0/2] Remove support for legacy UFS Avri Altman
2024-03-26 8:32 ` [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions Avri Altman
2024-03-26 17:20 ` Bart Van Assche
2024-03-26 17:22 ` Christoph Hellwig [this message]
2024-03-26 18:09 ` Avri Altman
2024-03-26 18:09 ` Avri Altman
2024-03-26 8:32 ` [PATCH 2/2] scsi: ufs: Remove legacy tuning calls Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgMEXZffmEqyRgVU@infradead.org \
--to=hch@infradead.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox