From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH] scsi: core: Disabe CDL by default
Date: Thu, 6 Jun 2024 02:32:49 -0700 [thread overview]
Message-ID: <ZmGCQTIjZjEpTJUR@infradead.org> (raw)
In-Reply-To: <20240606054606.55624-1-dlemoal@kernel.org>
On Thu, Jun 06, 2024 at 02:46:06PM +0900, Damien Le Moal wrote:
> However, for ATA devices, a drive may spin-up with the CDL feature
> either enabled or disabled by default, depending on the drive. But the
> scsi device cdl_enable field is always initialized to false (CDL
> disabled), regardless of the actual device CDL feature state.
The same should be true for native SCSI as well, right?
The patch itself looks good, though:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-06-06 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 5:46 [PATCH] scsi: core: Disabe CDL by default Damien Le Moal
2024-06-06 9:32 ` Christoph Hellwig [this message]
2024-06-06 12:11 ` Damien Le Moal
2024-06-06 13:23 ` Niklas Cassel
2024-06-06 15:13 ` Niklas Cassel
2024-06-06 23:11 ` Damien Le Moal
2024-06-06 15:48 ` Bart Van Assche
2024-06-06 23:08 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmGCQTIjZjEpTJUR@infradead.org \
--to=hch@infradead.org \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox