linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 1/2] block: also mark disk-owned queues as dying in __blk_mark_disk_dead
       [not found]     ` <20241016123240.GB18219@lst.de>
@ 2024-10-16 12:49       ` Ming Lei
  0 siblings, 0 replies; only message in thread
From: Ming Lei @ 2024-10-16 12:49 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Jens Axboe, Sergey Senozhatsky, YangYang, linux-block, linux-scsi,
	Martin K. Petersen

On Wed, Oct 16, 2024 at 02:32:40PM +0200, Christoph Hellwig wrote:
> On Wed, Oct 16, 2024 at 07:09:48PM +0800, Ming Lei wrote:
> > Setting QUEUE_FLAG_DYING may fail passthrough request for
> > !GD_OWNS_QUEUE, I guess this may cause SCSI regression.
> 
> Yes, as clearly documented in the commit log.

The change need Cc linux-scsi.

> As the disk is going away there is no real point in sending these
> commands, but we have no really good way to distinguish between the
> cases.  

scsi request queue has very different lifetime with gendisk, not sure the
above comment is correct.


Thanks,
Ming


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-10-16 12:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20241009113831.557606-1-hch@lst.de>
     [not found] ` <20241009113831.557606-2-hch@lst.de>
     [not found]   ` <Zw-e_CtNKeLJ3q1a@fedora>
     [not found]     ` <20241016123240.GB18219@lst.de>
2024-10-16 12:49       ` [PATCH 1/2] block: also mark disk-owned queues as dying in __blk_mark_disk_dead Ming Lei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).