Re: [PATCH v3 2/8] scsi: sd: Explicitly specify .ascq = SCMD_FAILURE_ASCQ_ANY for ASC 0x3a

[Bart Van Assche <bvanassche@acm.org>]

On 8/15/25 2:15 PM, Ewan D. Milne wrote:
> This makes the handling in read_capacity_10() consistent with other
> cases, e.g. sd_spinup_disk().  Omitting .ascq in scsi_failure did not
> result in wildcard matching, it only handled ASCQ 0x00.  This patch
> changes the retry behavior, we no longer retry 3 times on ASC 0x3a
> if a nonzero ASCQ is ever returned.
> 
> Signed-off-by: Ewan D. Milne <emilne@redhat.com>
> ---
>   drivers/scsi/sd.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 78f5903cc8d0..e3b802b26f0e 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -2729,11 +2729,13 @@ static int read_capacity_10(struct scsi_disk *sdkp, struct scsi_device *sdp,
>   		{
>   			.sense = UNIT_ATTENTION,
>   			.asc = 0x3A,
> +			.ascq = SCMD_FAILURE_ASCQ_ANY,
>   			.result = SAM_STAT_CHECK_CONDITION,
>   		},
>   		{
>   			.sense = NOT_READY,
>   			.asc = 0x3A,
> +			.ascq = SCMD_FAILURE_ASCQ_ANY,
>   			.result = SAM_STAT_CHECK_CONDITION,
>   		},
>   		 /* Device reset might occur several times so retry a lot */

If this patch is reposted, please consider shortening the title of this 
patch to e.g. "Do not retry ASC 0x3a". Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>