public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Ziqi Chen <quic_ziqichen@quicinc.com>,
	quic_cang@quicinc.com, mani@kernel.org, beanhuo@micron.com,
	avri.altman@wdc.com, junwoo80.lee@samsung.com,
	martin.petersen@oracle.com, quic_nguyenb@quicinc.com,
	quic_nitirawa@quicinc.com, quic_rampraka@quicinc.com
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
	Alim Akhtar <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Peter Wang <peter.wang@mediatek.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Eric Biggers <ebiggers@google.com>,
	Minwoo Im <minwoo.im@samsung.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/8] scsi: ufs: core: Add a vops to map clock frequency to gear speed
Date: Wed, 22 Jan 2025 10:30:08 -0800	[thread overview]
Message-ID: <a0359746-2cf0-4db3-891d-b4cb4ff6c163@acm.org> (raw)
In-Reply-To: <20250122100214.489749-4-quic_ziqichen@quicinc.com>

On 1/22/25 2:02 AM, Ziqi Chen wrote:
> +static inline int ufshcd_vops_freq_to_gear_speed(struct ufs_hba *hba,
> +						 unsigned long freq,
> +						 u32 *gear)
> +{
> +	if (hba->vops && hba->vops->freq_to_gear_speed)
> +		return hba->vops->freq_to_gear_speed(hba, freq, gear);
> +
> +	return -EOPNOTSUPP;
> +}

Please remove "vops_" from the function name. I don't think this part of 
the function name is useful. Additionally, please return the gear value 
as the function result and remove the "u32 *gear" argument.

Thanks,

Bart.

  parent reply	other threads:[~2025-01-22 18:30 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 10:02 [PATCH v2 0/8] Support Multi-frequency scale for UFS Ziqi Chen
2025-01-22 10:02 ` [PATCH v2 1/8] scsi: ufs: core: Pass target_freq to clk_scale_notify() vops Ziqi Chen
2025-01-22 14:08   ` Bean Huo
2025-01-22 18:19   ` Bart Van Assche
2025-01-23  7:37     ` Ziqi Chen
2025-01-22 10:02 ` [PATCH v2 2/8] scsi: ufs: qcom: Pass target_freq to clk scale pre and post change Ziqi Chen
2025-01-22 14:29   ` Bean Huo
2025-01-22 18:20   ` Bart Van Assche
2025-01-23  7:38     ` Ziqi Chen
2025-01-22 10:02 ` [PATCH v2 3/8] scsi: ufs: core: Add a vops to map clock frequency to gear speed Ziqi Chen
2025-01-22 15:30   ` Bean Huo
2025-01-22 18:22   ` Bart Van Assche
2025-01-23  7:38     ` Ziqi Chen
2025-01-22 18:30   ` Bart Van Assche [this message]
2025-01-23  7:40     ` Ziqi Chen
2025-01-23 17:49       ` Bart Van Assche
2025-01-24  2:38         ` Ziqi Chen
2025-01-22 10:02 ` [PATCH v2 4/8] scsi: ufs: qcom: Implement the freq_to_gear_speed() vops Ziqi Chen
2025-01-22 17:15   ` Bean Huo
2025-01-22 18:21   ` Eric Biggers
2025-01-23  7:38     ` Ziqi Chen
2025-01-22 18:23   ` Bart Van Assche
2025-01-23  7:39     ` Ziqi Chen
2025-01-22 10:02 ` [PATCH v2 5/8] scsi: ufs: core: Enable multi-level gear scaling Ziqi Chen
2025-01-22 18:32   ` Bart Van Assche
2025-01-23  7:41     ` Ziqi Chen
2025-01-23 18:02       ` Bart Van Assche
2025-01-24  2:41         ` Ziqi Chen
2025-01-22 10:02 ` [PATCH v2 6/8] scsi: ufs: core: Check if scaling up is required when disable clkscale Ziqi Chen
2025-01-22 10:02 ` [PATCH v2 7/8] scsi: ufs: core: Toggle Write Booster during clock scaling base on gear speed Ziqi Chen
2025-01-22 10:02 ` [PATCH v2 8/8] ABI: sysfs-driver-ufs: Add missing UFS sysfs addributes Ziqi Chen
2025-01-22 18:35   ` Bart Van Assche
2025-01-23  7:41     ` Ziqi Chen
2025-01-23 11:36   ` Bryan O'Donoghue
2025-01-24  2:44     ` Ziqi Chen
2025-01-23 20:12 ` [PATCH v2 0/8] Support Multi-frequency scale for UFS neil.armstrong
2025-01-24  3:50   ` Ziqi Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0359746-2cf0-4db3-891d-b4cb4ff6c163@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=ebiggers@google.com \
    --cc=junwoo80.lee@samsung.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=minwoo.im@samsung.com \
    --cc=peter.wang@mediatek.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    --cc=quic_rampraka@quicinc.com \
    --cc=quic_ziqichen@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox