Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: John Garry <john.garry@linux.dev>
To: yangxingui <yangxingui@huawei.com>,
	yanaijie@huawei.com, jejb@linux.ibm.com, mkp@kernel.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxarm@huawei.com, liuyonglong@huawei.com,
	kangfenglong@huawei.com
Subject: Re: [PATCH v4] scsi: libsas: Fix SMP IO deadlock during HA resume
Date: Wed, 14 Oct 2026 13:18:31 +0100	[thread overview]
Message-ID: <a114aeca-8e9f-4353-9dd3-9ce077f6fba4@linux.dev> (raw)
In-Reply-To: <ba5d9188-937c-237c-e104-9b66e7c3be3e@huawei.com>

On 10/8/26 04:11, yangxingui wrote:
>>> Fixes: 3dbbbf656b850 ("scsi: libsas: Fix HA resume deadlock and 
>>> hisi_sas disk-wake race")
>>> Signed-off-by: Xingui Yang <yangxingui@huawei.com>
>>
>> Question: do you have a (non-hisi_sas) SAS HBA card whose driver uses 
>> libsas? pm8001 would be such an example. It would be nice to verify 
>> that all these and other non-rpm libsas changes does cause regression 
>> there.
> 
> We don't have a pm8001 card at hand. From analysis the patch is a
> no-op for the LLDDs without runtime PM support: pm8001 and isci

It would be good if you could get another card whose driver uses libsas 
to verify these and any changes.

Anyway, the patch looks ok, so:

Reviewed-by: John Garry <john.garry@linux.dev>

  reply	other threads:[~2026-10-14 12:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  4:02 [PATCH v4] scsi: libsas: Fix SMP IO deadlock during HA resume Xingui Yang
2026-09-28  4:14 ` sashiko-bot
2026-09-28  7:30   ` yangxingui
2026-09-30 10:40 ` John Garry
2026-10-08  3:11   ` yangxingui
2026-10-14 12:18     ` John Garry [this message]
2026-10-15  3:02 ` Martin K. Petersen (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a114aeca-8e9f-4353-9dd3-9ce077f6fba4@linux.dev \
    --to=john.garry@linux.dev \
    --cc=jejb@linux.ibm.com \
    --cc=kangfenglong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=mkp@kernel.org \
    --cc=yanaijie@huawei.com \
    --cc=yangxingui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox