public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Chao Yu <chao@kernel.org>
Cc: jejb@linux.ibm.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH v4] scsi: support packing multi-segment in UNMAP command
Date: Thu, 11 Aug 2022 12:34:15 -0700	[thread overview]
Message-ID: <a15badd3-b9db-929f-1dc2-863fbff03992@acm.org> (raw)
In-Reply-To: <yq1wndgnj4i.fsf@ca-mkp.ca.oracle.com>

On 6/16/22 19:01, Martin K. Petersen wrote:
>> As SCSI SBC4 specification section 5.30.2 describes that it can
>> support unmapping one or more LBA range in single UNMAP command.
>>
>> However, previously we only pack one LBA range in UNMAP command by
>> default no matter device gives the block limits that says it can
>> support unmapping multiple LBA ranges with a single UNMAP command.
>>
>> This patch sets max_discard_segments config according to block limits
>> of device, and supports unmapping multiple LBA ranges with a single
>> UNMAP command.
> 
> This looks OK to me. Will test with a variety of targets.

Hi Martin,

Have you already had the chance to test this patch? We would like to use 
this functionality in Android.

Thanks,

Bart.



  reply	other threads:[~2022-08-11 19:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  1:36 [PATCH v4] scsi: support packing multi-segment in UNMAP command Chao Yu
2022-06-16  6:09 ` Christoph Hellwig
2022-06-17  2:01 ` Martin K. Petersen
2022-08-11 19:34   ` Bart Van Assche [this message]
2022-08-12  1:53     ` Martin K. Petersen
2022-08-12  5:59       ` Chao Yu
2022-06-17  3:50 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a15badd3-b9db-929f-1dc2-863fbff03992@acm.org \
    --to=bvanassche@acm.org \
    --cc=chao@kernel.org \
    --cc=hch@infradead.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox