* [PATCH v2] ufs: introduce setup_task_mgmt
@ 2016-11-10 12:16 Kiwoong Kim
2016-11-10 18:15 ` Subhash Jadavani
0 siblings, 1 reply; 2+ messages in thread
From: Kiwoong Kim @ 2016-11-10 12:16 UTC (permalink / raw)
To: linux-scsi, vinholikatti; +Cc: cpgs, HeonGwang Chu
Some UFS host controller may need to configure some things
before any task management request is issued
v2: move a comment to another place
Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
---
drivers/scsi/ufs/ufshcd.c | 2 ++
drivers/scsi/ufs/ufshcd.h | 10 ++++++++++
2 files changed, 12 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index bf78321..301b592 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4357,6 +4357,8 @@ static int ufshcd_issue_tm_cmd(struct ufs_hba *hba, int lun_id, int task_id,
task_req_upiup->input_param1 = cpu_to_be32(lun_id);
task_req_upiup->input_param2 = cpu_to_be32(task_id);
+ ufshcd_vops_setup_task_mgmt(hba, free_slot, tm_function);
+
/* send command to the controller */
__set_bit(free_slot, &hba->outstanding_tasks);
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index e935fd1..05d8384 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -263,6 +263,8 @@ struct ufs_pwr_mode_info {
* to be set.
* @setup_xfer_req: called before any transfer request is issued
* to set some things
+ * @setup_task_mgmt: called before any task management request is issued
+ * to set some things
* @suspend: called during host controller PM callback
* @resume: called during host controller PM callback
* @dbg_register_dump: used to dump controller debug information
@@ -287,6 +289,7 @@ struct ufs_hba_variant_ops {
struct ufs_pa_layer_attr *,
struct ufs_pa_layer_attr *);
void (*setup_xfer_req)(struct ufs_hba *, int, bool);
+ void (*setup_task_mgmt)(struct ufs_hba *, int, u8);
int (*suspend)(struct ufs_hba *, enum ufs_pm_op);
int (*resume)(struct ufs_hba *, enum ufs_pm_op);
void (*dbg_register_dump)(struct ufs_hba *hba);
@@ -811,6 +814,13 @@ static inline void ufshcd_vops_setup_xfer_req(struct ufs_hba *hba, int tag,
return hba->vops->setup_xfer_req(hba, tag, is_scsi_cmd);
}
+static inline void ufshcd_vops_setup_task_mgmt(struct ufs_hba *hba,
+ int tag, u8 tm_function)
+{
+ if (hba->vops && hba->vops->setup_task_mgmt)
+ return hba->vops->setup_task_mgmt(hba, tag, tm_function);
+}
+
static inline int ufshcd_vops_suspend(struct ufs_hba *hba, enum ufs_pm_op op)
{
if (hba->vops && hba->vops->suspend)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ufs: introduce setup_task_mgmt
2016-11-10 12:16 [PATCH v2] ufs: introduce setup_task_mgmt Kiwoong Kim
@ 2016-11-10 18:15 ` Subhash Jadavani
0 siblings, 0 replies; 2+ messages in thread
From: Subhash Jadavani @ 2016-11-10 18:15 UTC (permalink / raw)
To: Kiwoong Kim
Cc: linux-scsi, vinholikatti, cpgs, HeonGwang Chu, linux-scsi-owner
On 2016-11-10 04:16, Kiwoong Kim wrote:
> Some UFS host controller may need to configure some things
> before any task management request is issued
>
> v2: move a comment to another place
>
> Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 ++
> drivers/scsi/ufs/ufshcd.h | 10 ++++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index bf78321..301b592 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4357,6 +4357,8 @@ static int ufshcd_issue_tm_cmd(struct ufs_hba
> *hba, int lun_id, int task_id,
> task_req_upiup->input_param1 = cpu_to_be32(lun_id);
> task_req_upiup->input_param2 = cpu_to_be32(task_id);
>
> + ufshcd_vops_setup_task_mgmt(hba, free_slot, tm_function);
> +
> /* send command to the controller */
> __set_bit(free_slot, &hba->outstanding_tasks);
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index e935fd1..05d8384 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -263,6 +263,8 @@ struct ufs_pwr_mode_info {
> * to be set.
> * @setup_xfer_req: called before any transfer request is issued
> * to set some things
> + * @setup_task_mgmt: called before any task management request is
> issued
> + * to set some things
> * @suspend: called during host controller PM callback
> * @resume: called during host controller PM callback
> * @dbg_register_dump: used to dump controller debug information
> @@ -287,6 +289,7 @@ struct ufs_hba_variant_ops {
> struct ufs_pa_layer_attr *,
> struct ufs_pa_layer_attr *);
> void (*setup_xfer_req)(struct ufs_hba *, int, bool);
> + void (*setup_task_mgmt)(struct ufs_hba *, int, u8);
> int (*suspend)(struct ufs_hba *, enum ufs_pm_op);
> int (*resume)(struct ufs_hba *, enum ufs_pm_op);
> void (*dbg_register_dump)(struct ufs_hba *hba);
> @@ -811,6 +814,13 @@ static inline void
> ufshcd_vops_setup_xfer_req(struct ufs_hba *hba, int tag,
> return hba->vops->setup_xfer_req(hba, tag, is_scsi_cmd);
> }
>
> +static inline void ufshcd_vops_setup_task_mgmt(struct ufs_hba *hba,
> + int tag, u8 tm_function)
> +{
> + if (hba->vops && hba->vops->setup_task_mgmt)
> + return hba->vops->setup_task_mgmt(hba, tag, tm_function);
> +}
> +
> static inline int ufshcd_vops_suspend(struct ufs_hba *hba, enum
> ufs_pm_op op)
> {
> if (hba->vops && hba->vops->suspend)
LGTM.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-10 18:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 12:16 [PATCH v2] ufs: introduce setup_task_mgmt Kiwoong Kim
2016-11-10 18:15 ` Subhash Jadavani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).