From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <beanhuo@iokpp.de>,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, can.guo@oss.qualcomm.com,
ulf.hansson@linaro.org, beanhuo@micron.com,
jens.wiklander@linaro.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] rpmb: move rpmb_frame struct and constants to common header
Date: Tue, 23 Sep 2025 13:28:40 -0700 [thread overview]
Message-ID: <a41bd12c-37c8-46d0-9fe3-c9ef0ca7cd95@acm.org> (raw)
In-Reply-To: <20250923153906.1751813-2-beanhuo@iokpp.de>
On 9/23/25 8:39 AM, Bean Huo wrote:
> +struct rpmb_frame {
> + u8 stuff[196];
> + u8 key_mac[32];
> + u8 data[256];
> + u8 nonce[16];
> + __be32 write_counter __packed;
> + __be16 addr __packed;
> + __be16 block_count __packed;
> + __be16 result __packed;
> + __be16 req_resp __packed;
> +};
I think that it is safe to remove __packed from the above structure
members since the size of the first four members is a multiple of four
(196 + 32 + 256 + 16) and that is sufficient not to introduce any gaps
between the __be* members.
Thanks,
Bart.
next prev parent reply other threads:[~2025-09-23 20:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 15:39 [PATCH v1 0/3] Add OP-TEE based RPMB driver for UFS devices Bean Huo
2025-09-23 15:39 ` [PATCH v1 1/3] rpmb: move rpmb_frame struct and constants to common header Bean Huo
2025-09-23 20:28 ` Bart Van Assche [this message]
2025-09-24 6:12 ` Avri Altman
2025-09-25 14:51 ` Bean Huo
2025-09-25 15:45 ` Avri Altman
2025-09-23 15:39 ` [PATCH v1 2/3] scsi: ufs: core: fix incorrect buffer duplication in ufshcd_read_string_desc() Bean Huo
2025-09-23 16:57 ` Bart Van Assche
2025-09-23 15:39 ` [PATCH v1 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices Bean Huo
2025-09-23 20:27 ` Bart Van Assche
2025-09-27 8:40 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a41bd12c-37c8-46d0-9fe3-c9ef0ca7cd95@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@iokpp.de \
--cc=beanhuo@micron.com \
--cc=can.guo@oss.qualcomm.com \
--cc=jejb@linux.ibm.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).