* [PATCH] scsi: ufs: Remove a ufshcd_add_command_trace() call
@ 2023-05-31 22:40 Bart Van Assche
2023-06-07 17:18 ` Bart Van Assche
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Bart Van Assche @ 2023-05-31 22:40 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Jaegeuk Kim, linux-scsi, Adrian Hunter, Bart Van Assche,
James E.J. Bottomley, Stanley Chu, Asutosh Das, Avri Altman,
Bean Huo, Ziqi Chen, Arthur Simchaev, Adrien Thierry
ufshcd_add_command_trace() traces SCSI commands. Remove a
ufshcd_add_command_trace() call from a code path that is not related to
SCSI commands.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufshcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 0856f01b761d..1f7a4ec211ff 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
if (hba->dev_cmd.complete) {
hba->dev_cmd.cqe = cqe;
- ufshcd_add_command_trace(hba, task_tag, UFS_DEV_COMP);
complete(hba->dev_cmd.complete);
ufshcd_clk_scaling_update_busy(hba);
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Remove a ufshcd_add_command_trace() call
2023-05-31 22:40 [PATCH] scsi: ufs: Remove a ufshcd_add_command_trace() call Bart Van Assche
@ 2023-06-07 17:18 ` Bart Van Assche
2023-06-07 17:36 ` Avri Altman
2023-06-07 20:55 ` Bean Huo
2023-06-08 1:05 ` Martin K. Petersen
2 siblings, 1 reply; 5+ messages in thread
From: Bart Van Assche @ 2023-06-07 17:18 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Jaegeuk Kim, linux-scsi, Adrian Hunter, James E.J. Bottomley,
Stanley Chu, Asutosh Das, Avri Altman, Bean Huo, Ziqi Chen,
Arthur Simchaev, Adrien Thierry
On 5/31/23 15:40, Bart Van Assche wrote:
> ufshcd_add_command_trace() traces SCSI commands. Remove a
> ufshcd_add_command_trace() call from a code path that is not related to
> SCSI commands.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/ufs/core/ufshcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 0856f01b761d..1f7a4ec211ff 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
> lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
> if (hba->dev_cmd.complete) {
> hba->dev_cmd.cqe = cqe;
> - ufshcd_add_command_trace(hba, task_tag, UFS_DEV_COMP);
> complete(hba->dev_cmd.complete);
> ufshcd_clk_scaling_update_busy(hba);
> }
Can anyone please help with reviewing this patch?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] scsi: ufs: Remove a ufshcd_add_command_trace() call
2023-06-07 17:18 ` Bart Van Assche
@ 2023-06-07 17:36 ` Avri Altman
0 siblings, 0 replies; 5+ messages in thread
From: Avri Altman @ 2023-06-07 17:36 UTC (permalink / raw)
To: Bart Van Assche, Martin K . Petersen
Cc: Jaegeuk Kim, linux-scsi@vger.kernel.org, Adrian Hunter,
James E.J. Bottomley, Stanley Chu, Asutosh Das, Bean Huo,
Ziqi Chen, Arthur Simchaev, Adrien Thierry
> On 5/31/23 15:40, Bart Van Assche wrote:
> > ufshcd_add_command_trace() traces SCSI commands. Remove a
> > ufshcd_add_command_trace() call from a code path that is not related to
> > SCSI commands.
> >
> > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
> > ---
> > drivers/ufs/core/ufshcd.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> > index 0856f01b761d..1f7a4ec211ff 100644
> > --- a/drivers/ufs/core/ufshcd.c
> > +++ b/drivers/ufs/core/ufshcd.c
> > @@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,
> int task_tag,
> > lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
> > if (hba->dev_cmd.complete) {
> > hba->dev_cmd.cqe = cqe;
> > - ufshcd_add_command_trace(hba, task_tag, UFS_DEV_COMP);
> > complete(hba->dev_cmd.complete);
> > ufshcd_clk_scaling_update_busy(hba);
> > }
>
> Can anyone please help with reviewing this patch?
>
> Thanks,
>
> Bart.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Remove a ufshcd_add_command_trace() call
2023-05-31 22:40 [PATCH] scsi: ufs: Remove a ufshcd_add_command_trace() call Bart Van Assche
2023-06-07 17:18 ` Bart Van Assche
@ 2023-06-07 20:55 ` Bean Huo
2023-06-08 1:05 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Bean Huo @ 2023-06-07 20:55 UTC (permalink / raw)
To: Bart Van Assche, Martin K . Petersen
Cc: Jaegeuk Kim, linux-scsi, Adrian Hunter, James E.J. Bottomley,
Stanley Chu, Asutosh Das, Avri Altman, Bean Huo, Ziqi Chen,
Arthur Simchaev, Adrien Thierry
On 01.06.23 12:40 AM, Bart Van Assche wrote:
> ufshcd_add_command_trace() traces SCSI commands. Remove a
> ufshcd_add_command_trace() call from a code path that is not related to
> SCSI commands.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/ufs/core/ufshcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 0856f01b761d..1f7a4ec211ff 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
> lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
> if (hba->dev_cmd.complete) {
> hba->dev_cmd.cqe = cqe;
> - ufshcd_add_command_trace(hba, task_tag, UFS_DEV_COMP);
> complete(hba->dev_cmd.complete);
> ufshcd_clk_scaling_update_busy(hba);
> }
The tracepoint entry here is of no use, it's never executed, it just
returns.
Reviewed-by: Bean Huo <beanhuo@micron.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Remove a ufshcd_add_command_trace() call
2023-05-31 22:40 [PATCH] scsi: ufs: Remove a ufshcd_add_command_trace() call Bart Van Assche
2023-06-07 17:18 ` Bart Van Assche
2023-06-07 20:55 ` Bean Huo
@ 2023-06-08 1:05 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-06-08 1:05 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, Jaegeuk Kim, linux-scsi, Adrian Hunter,
James E.J. Bottomley, Stanley Chu, Asutosh Das, Avri Altman,
Bean Huo, Ziqi Chen, Arthur Simchaev, Adrien Thierry
Bart,
> ufshcd_add_command_trace() traces SCSI commands. Remove a
> ufshcd_add_command_trace() call from a code path that is not related to
> SCSI commands.
Applied to 6.5/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-08 1:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-31 22:40 [PATCH] scsi: ufs: Remove a ufshcd_add_command_trace() call Bart Van Assche
2023-06-07 17:18 ` Bart Van Assche
2023-06-07 17:36 ` Avri Altman
2023-06-07 20:55 ` Bean Huo
2023-06-08 1:05 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox