From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "quic_mnaresh@quicinc.com" <quic_mnaresh@quicinc.com>,
"mikebi@micron.com" <mikebi@micron.com>,
"lporzio@micron.com" <lporzio@micron.com>,
"linux@weissschuh.net" <linux@weissschuh.net>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>
Subject: Re: [PATCH] scsi: ufs: Start the RTC update work later
Date: Fri, 1 Nov 2024 06:27:10 +0000 [thread overview]
Message-ID: <a5a9bdaf7ec37002e9203532874d98ff1106906c.camel@mediatek.com> (raw)
In-Reply-To: <20241031212632.2799127-1-bvanassche@acm.org>
On Thu, 2024-10-31 at 14:26 -0700, Bart Van Assche wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> The RTC update work involves runtime resuming the UFS controller.
> Hence,
> only start the RTC update work after runtime power management in the
> UFS
> driver has been fully initialized. This patch fixes the following
> kernel
> crash:
>
> Internal error: Oops: 0000000096000006 [#1] PREEMPT SMP
> Workqueue: events ufshcd_rtc_work
> Call trace:
> _raw_spin_lock_irqsave+0x34/0x8c (P)
> pm_runtime_get_if_active+0x24/0x9c (L)
> pm_runtime_get_if_active+0x24/0x9c
> ufshcd_rtc_work+0x138/0x1b4
> process_one_work+0x148/0x288
> worker_thread+0x2cc/0x3d4
> kthread+0x110/0x114
> ret_from_fork+0x10/0x20
>
> Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
> Closes:
> https://lore.kernel.org/linux-scsi/0c0bc528-fdc2-4106-bc99-f23ae377f6f5@linaro.org/
> Fixes: 6bf999e0eb41 ("scsi: ufs: core: Add UFS RTC support")
> Cc: Bean Huo <beanhuo@micron.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2024-11-01 6:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 21:26 [PATCH] scsi: ufs: Start the RTC update work later Bart Van Assche
2024-11-01 6:27 ` Peter Wang (王信友) [this message]
2024-11-01 7:53 ` Manivannan Sadhasivam
2024-11-01 16:31 ` Bart Van Assche
2024-11-02 10:21 ` Manivannan Sadhasivam
2024-11-01 21:03 ` Bean Huo
2024-11-04 13:43 ` Neil Armstrong
2024-11-05 2:31 ` Martin K. Petersen
2024-11-05 3:48 ` James Bottomley
2024-11-05 18:54 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5a9bdaf7ec37002e9203532874d98ff1106906c.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=lporzio@micron.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=mikebi@micron.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_mnaresh@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox