Re: [PATCH v2] ata: libata-scsi: Fix get identity data failed

Jason Yan
2023-05-06T02:11:08Z

On 2023/5/5 17:14, yangxingui wrote:
>
>
> On 2023/5/5 16:25, John Garry wrote:
>> On 05/05/2023 09:17, Damien Le Moal wrote:
>>>> --- a/drivers/ata/libata-scsi.c
>>>> +++ b/drivers/ata/libata-scsi.c
>>>> @@ -26,6 +26,7 @@
>>>>   #include <scsi/scsi_device.h>
>>>>   #include <scsi/scsi_tcq.h>
>>>>   #include <scsi/scsi_transport.h>
>>>> +#include <scsi/libsas.h>
>>
>> hmmm... is it really acceptable that libata is referencing libsas? I
>> didn't think that it would be. libsas uses libata, not the other way
>> around.
> Yeah, I didn't expect that either. Is there any other way? If so, is
> patch v1 OK?

Hi Xingui,

Libsas should follow the standard way of libata to manage the ata
structures. Not the opposite way. So what you should do is to find a way
for libsas to behave as a normal ata driver. It's not good to make
libata aware of libsas or referencing libsas.

If you have detailed questions you can ask me internally(which will be
faster) or publicly through the maillist(which may have some delay).

Thanks,
Jason