From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
Laurence Oberman <loberman@redhat.com>,
Paolo Valente <paolo.valente@linaro.org>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
Tom Nguyen <tom81094@gmail.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Omar Sandoval <osandov@fb.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH V8 1/7] blk-mq-sched: fix scheduler bad performance
Date: Fri, 13 Oct 2017 11:30:16 -0600 [thread overview]
Message-ID: <a6bbbd2d-3469-129e-2bae-82fa7efb29f1@kernel.dk> (raw)
In-Reply-To: <20171013172459.1376-2-ming.lei@redhat.com>
On 10/13/2017 11:24 AM, Ming Lei wrote:
> When hw queue is busy, we shouldn't take requests from
> scheduler queue any more, otherwise it is difficult to do
> IO merge.
>
> This patch fixes the awful IO performance on some
> SCSI devices(lpfc, qla2xxx, ...) when mq-deadline/kyber
> is used by not taking requests if hw queue is busy.
This looks fine to me, but needs a much better patch title.
"fix scheduler bad performance" tells you nothing.
--
Jens Axboe
next prev parent reply other threads:[~2017-10-13 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 17:24 [PATCH V8 0/7] blk-mq-sched: improve sequential I/O performance Ming Lei
2017-10-13 17:24 ` [PATCH V8 1/7] blk-mq-sched: fix scheduler bad performance Ming Lei
2017-10-13 17:30 ` Jens Axboe [this message]
2017-10-13 17:24 ` [PATCH V8 2/7] blk-mq-sched: move actual dispatching into one helper Ming Lei
2017-10-13 17:24 ` [PATCH V8 3/7] sbitmap: introduce __sbitmap_for_each_set() Ming Lei
2017-10-13 17:24 ` [PATCH V8 4/7] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops Ming Lei
2017-10-13 17:32 ` Jens Axboe
2017-10-13 17:24 ` [PATCH V8 5/7] blk-mq-sched: improve dispatching from sw queue Ming Lei
2017-10-13 17:24 ` [PATCH V8 6/7] SCSI: allow to pass null rq to scsi_prep_state_check() Ming Lei
2017-10-13 17:24 ` [PATCH V8 7/7] SCSI: implement .get_budget and .put_budget for blk-mq Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6bbbd2d-3469-129e-2bae-82fa7efb29f1@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=hch@infradead.org \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=osandov@fb.com \
--cc=paolo.valente@linaro.org \
--cc=tom81094@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).