From: Bart Van Assche <bvanassche@acm.org>
To: Abinash Singh <abinashsinghlalotra@gmail.com>
Cc: James.Bottomley@HansenPartnership.com, dlemoal@kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com
Subject: Re: [PATCH v10 2/3] scsi: sd: Remove redundant printk after kmalloc failure
Date: Mon, 25 Aug 2025 12:26:26 -0700 [thread overview]
Message-ID: <a78bcbfc-a81f-4266-a646-82fad1044f79@acm.org> (raw)
In-Reply-To: <20250825183940.13211-3-abinashsinghlalotra@gmail.com>
On 8/25/25 11:39 AM, Abinash Singh wrote:
> Remove the unnecessary sd_printk() call. Control flow is unchanged.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2025-08-25 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 18:39 [PATCH v10 0/3] scsi: sd: Cleanups and warning fixes in sd_revalidate_disk() Abinash Singh
2025-08-25 18:39 ` [PATCH v10 1/3] scsi: sd: Fix build warning " Abinash Singh
2025-08-26 5:10 ` Damien Le Moal
2025-08-25 18:39 ` [PATCH v10 2/3] scsi: sd: Remove redundant printk after kmalloc failure Abinash Singh
2025-08-25 19:26 ` Bart Van Assche [this message]
2025-08-25 18:39 ` [PATCH v10 3/3] scsi: sd: make sd_revalidate_disk() return void Abinash Singh
2025-08-26 5:10 ` Damien Le Moal
2025-08-31 1:19 ` [PATCH v10 0/3] scsi: sd: Cleanups and warning fixes in sd_revalidate_disk() Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a78bcbfc-a81f-4266-a646-82fad1044f79@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abinashsinghlalotra@gmail.com \
--cc=dlemoal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).