* [PATCH] ibmvscsis: Fix write_pending failure path
@ 2017-10-02 17:59 Bryant G. Ly
2017-10-03 2:51 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: Bryant G. Ly @ 2017-10-02 17:59 UTC (permalink / raw)
To: nab; +Cc: seroyer, linux-scsi, target-devel, Bryant G. Ly
From: "Bryant G. Ly" <bgly@us.ibm.com>
For write_pending if the queue is down or client failed
then return -EIO so that LIO can properly process the
completed command. Prior we returned 0 since LIO could
not handle it properly. Now with:
target: Fix unknown fabric callback queue-full errors
that patch addresses LIO's ability to handle things right.
Signed-off-by: Bryant G. Ly <bgly@us.ibm.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index 1f75d0380516f..fe5b9d7bc06df 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3767,7 +3767,7 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd)
*/
if ((vscsi->flags & (CLIENT_FAILED | RESPONSE_Q_DOWN))) {
pr_err("write_pending failed since: %d\n", vscsi->flags);
- return 0;
+ return -EIO;
}
rc = srp_transfer_data(cmd, &vio_iu(iue)->srp.cmd, ibmvscsis_rdma,
--
2.13.5 (Apple Git-94)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ibmvscsis: Fix write_pending failure path
2017-10-02 17:59 [PATCH] ibmvscsis: Fix write_pending failure path Bryant G. Ly
@ 2017-10-03 2:51 ` Martin K. Petersen
2017-10-03 15:13 ` Bryant G. Ly
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2017-10-03 2:51 UTC (permalink / raw)
To: Bryant G. Ly; +Cc: nab, seroyer, linux-scsi, target-devel, Bryant G. Ly
Bryant,
> For write_pending if the queue is down or client failed then return
> -EIO so that LIO can properly process the completed command. Prior we
> returned 0 since LIO could not handle it properly. Now with: target:
> Fix unknown fabric callback queue-full errors that patch addresses
> LIO's ability to handle things right.
Applied to 4.14/scsi-fixes. thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ibmvscsis: Fix write_pending failure path
2017-10-03 2:51 ` Martin K. Petersen
@ 2017-10-03 15:13 ` Bryant G. Ly
0 siblings, 0 replies; 3+ messages in thread
From: Bryant G. Ly @ 2017-10-03 15:13 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: nab, seroyer, linux-scsi, target-devel, Bryant G. Ly
On 10/2/17 9:51 PM, Martin K. Petersen wrote:
> Bryant,
>
>> For write_pending if the queue is down or client failed then return
>> -EIO so that LIO can properly process the completed command. Prior we
>> returned 0 since LIO could not handle it properly. Now with: target:
>> Fix unknown fabric callback queue-full errors that patch addresses
>> LIO's ability to handle things right.
> Applied to 4.14/scsi-fixes. thanks!
>
Thanks! I forgot to add the stable tag for 4.11+, but I guess we can
wait for
Nick to reply since we had discussed making the dependent patch series
stable.
[PATCH 0/3] target: Fix queue-full callback error signaling
fa7e25cf13a6d0b82b5ed1008246f44d42e8422c
a4467018c2a7228f4ef58051f0511bd037bff264
025def92dd6b5b84b0d6d9069e2bb24e51e48c17
-Bryant
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-03 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-02 17:59 [PATCH] ibmvscsis: Fix write_pending failure path Bryant G. Ly
2017-10-03 2:51 ` Martin K. Petersen
2017-10-03 15:13 ` Bryant G. Ly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).