Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"nbd@other.debian.org" <nbd@other.debian.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: blktests failures with v6.19 kernel
Date: Tue, 17 Feb 2026 21:22:29 +0000	[thread overview]
Message-ID: <a85b9d47-d52d-4ef5-8221-aef3e179925b@nvidia.com> (raw)
In-Reply-To: <1a4f4064-8352-49c3-a7f5-3883c2c13025@flourine.local>

On 2/16/26 02:26, Daniel Wagner wrote:
> Hi Chaitanya,
>
> On Sat, Feb 14, 2026 at 09:19:47PM +0000, Chaitanya Kulkarni wrote:
>> On 2/13/26 01:56, Daniel Wagner wrote:
>>> nvmet_fc_target_assoc_free runs in the nvmet_wq context and calls
>>>
>>>     nvmet_fc_delete_target_queue
>>>       nvmet_cq_put
>>>         nvmet_cq_destroy
>>>           nvmet_ctrl_put
>>>            nvmet_ctrl_free
>>>              flush_work(&ctrl->async_event_work);
>>>              cancel_work_sync(&ctrl->fatal_err_work);
>>>    
>>> The async_event_work could be running on nvmet_wq. So this deadlock is
>>> real. No idea how to fix it yet.
>>>
>> Can following patch be the potential fix for above issue as well ?
>> totally untested ...
> Yes this should work. I was not so happy adding a workqueue for this but
> after looking at nvme, this seems acceptable approach. Though, I'd make
> nvmet follow the nvme and instead adding an AEN workqueue, rather have a
> nvmet-reset-wq or nvmet_delete-wq.
>
> Thanks,
> Daniel


Thanks for looking into this.

The above patch has a cleanup bug, I've sent better patch, please have a look
hopefully we can get this merged this week.

-ck



  reply	other threads:[~2026-02-17 21:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  7:57 blktests failures with v6.19 kernel Shinichiro Kawasaki
2026-02-13  9:56 ` Daniel Wagner
2026-02-14 21:19   ` Chaitanya Kulkarni
2026-02-16 10:26     ` Daniel Wagner
2026-02-17 21:22       ` Chaitanya Kulkarni [this message]
2026-02-13 17:44 ` Bart Van Assche
2026-02-13 23:38   ` yanjun.zhu
2026-02-16  9:38 ` Nilay Shroff
2026-02-16 21:18   ` Chaitanya Kulkarni
2026-02-24  7:47 ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a85b9d47-d52d-4ef5-8221-aef3e179925b@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=dwagner@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nbd@other.debian.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox