From: John Garry <john.g.garry@oracle.com>
To: Jason Yan <yanaijie@huawei.com>,
martin.petersen@oracle.com, jejb@linux.ibm.com
Cc: linux-scsi@vger.kernel.org, hare@suse.com, hch@lst.de,
bvanassche@acm.org, jinpu.wang@cloud.ionos.com,
damien.lemoal@opensource.wdc.com
Subject: Re: [PATCH v2 1/5] scsi: libsas: move sas_get_ata_command_set() up to save the declaration
Date: Tue, 13 Dec 2022 16:00:20 +0000 [thread overview]
Message-ID: <a8a2a6f6-b322-45a0-50f2-0a777cb90dcd@oracle.com> (raw)
In-Reply-To: <20221213150942.988371-2-yanaijie@huawei.com>
On 13/12/2022 15:09, Jason Yan wrote:
> There is a sas_get_ata_command_set() declaration above sas_get_ata_info()
> to make it compile ok. However this function is defined in the same file
> below. So move it up to save the declaration.
nit: forward declaration
>
> Also remove the variable 'fis' which is not needed in this function.
>
> Cc: John Garry<john.g.garry@oracle.com>
> Signed-off-by: Jason Yan<yanaijie@huawei.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2022-12-13 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 15:09 [PATCH v2 0/5] scsi: libsas: Some coding style fixes and cleanups Jason Yan
2022-12-13 15:09 ` [PATCH v2 1/5] scsi: libsas: move sas_get_ata_command_set() up to save the declaration Jason Yan
2022-12-13 16:00 ` John Garry [this message]
2022-12-13 15:09 ` [PATCH v2 2/5] scsi: libsas: change the coding style of sas_discover_sata() Jason Yan
2022-12-13 16:08 ` John Garry
2022-12-13 15:09 ` [PATCH v2 3/5] scsi: libsas: remove useless dev_list delete in sas_ex_discover_end_dev() Jason Yan
2022-12-13 16:13 ` John Garry
2022-12-13 15:09 ` [PATCH v2 4/5] scsi: libsas: factor out sas_ata_add_dev() Jason Yan
2022-12-13 16:22 ` John Garry
2022-12-14 2:46 ` Jason Yan
2022-12-13 15:09 ` [PATCH v2 5/5] scsi: libsas: factor out sas_ex_add_dev() Jason Yan
2022-12-13 16:24 ` John Garry
2022-12-13 16:12 ` [PATCH v2 0/5] scsi: libsas: Some coding style fixes and cleanups John Garry
2022-12-14 2:54 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8a2a6f6-b322-45a0-50f2-0a777cb90dcd@oracle.com \
--to=john.g.garry@oracle.com \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox