Re: [PATCH 03/14] lpfc: Fix first-burst driver implementation.

[James Smart <jsmart2021@gmail.com>]

On 7/1/2020 8:05 PM, Martin K. Petersen wrote:
> 
> James,
> 
>> - Upon PRLI completion, if first-burst is enabled and the target supports
>>    first burst, the driver will issue a modesense6 scsi command to obtain
>>    the disconnect-reconnect page that has transport specific limits. This
>>    page reports the max first-burst size supported on the target. The size
>>    supported is saved in the target node structure.
> 
> I didn't make it beyond this patch :(
> 
> Why do this in the driver? If you need the Disconnect-Reconnect page,
> then let's ask for it in the core code. Maybe in the fc transport so we
> don't risk upsetting USB devices, etc. See sas_read_port_mode_page().
> 

Because it was rather awkward to coordinate, snoop, sample at the right 
time, and a lot more work when implemented in the midlayer.  I really 
don't like that scsi put transport controls in a scsi mode page.

I will take another look at it. It should be queried about the same time 
as when luns are first probed - lun 0 or report luns, or on the first 
lun probed as it's an I_T set of parameters. Not sure if it should be 
saved in the starget (fields are defined generically) or in the transport.

Please review the rest and I can repost for any comments on the other 
patches and I'll remove this patch.

-- james