public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Peter Wang (王信友)" <peter.wang@mediatek.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"hch@lst.de" <hch@lst.de>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Stanley Chu (朱原陞)" <stanley.chu@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"quic_cang@quicinc.com" <quic_cang@quicinc.com>
Subject: Re: [PATCH v10 13/18] scsi: ufs: mediatek: Rework the code for disabling auto-hibernation
Date: Tue, 22 Aug 2023 08:54:10 -0700	[thread overview]
Message-ID: <a97dcd51-07e1-8972-2661-2a1dd0048e91@acm.org> (raw)
In-Reply-To: <884fead2cdf88b2690e0aa87769684de60e26ac2.camel@mediatek.com>

On 8/22/23 02:20, Peter Wang (王信友) wrote:
> Cannot call ufshcd_auto_hibern8_update here.
> ufshcd_auto_hibern8_update will get runtime pm.
> but
> ufs_mtk_auto_hibern8_disable only used in runtime suspend flow.
> So, call ufshcd_auto_hibern8_update will get deadlock to wait runtime
> resume.

Hi Peter,

Thanks for the feedback. I'm going to drop this patch and also ufs-hisi
patch. Although that will lead to suboptimal performance if the user
enables auto-hibernation, users can achieve full performance for small
zoned writes by disabling auto-hibernation through sysfs.

Thanks,

Bart.


  reply	other threads:[~2023-08-22 15:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 19:34 [PATCH v10 00/18] Improve performance for zoned UFS devices Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 01/18] block: Introduce more member variables related to zone write locking Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 02/18] block: Only use write locking if necessary Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 03/18] block/mq-deadline: Only use zone " Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 04/18] scsi: core: Introduce a mechanism for reordering requests in the error handler Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 05/18] scsi: core: Add unit tests for scsi_call_prepare_resubmit() Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 06/18] scsi: sd: Sort commands by LBA before resubmitting Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 07/18] scsi: core: Retry unaligned zoned writes Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 08/18] scsi: sd_zbc: Only require an I/O scheduler if needed Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 09/18] scsi: scsi_debug: Add the preserves_write_order module parameter Bart Van Assche
2023-08-22  4:05   ` Douglas Gilbert
2023-08-18 19:34 ` [PATCH v10 10/18] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 11/18] scsi: ufs: Change the return type of ufshcd_auto_hibern8_update() Bart Van Assche
2023-08-18 21:05   ` Bao D. Nguyen
2023-08-21  5:30   ` Can Guo
2023-08-18 19:34 ` [PATCH v10 12/18] scsi: ufs: hisi: Rework the code that disables auto-hibernation Bart Van Assche
2023-08-18 21:09   ` Bao D. Nguyen
2023-08-18 19:34 ` [PATCH v10 13/18] scsi: ufs: mediatek: Rework the code for disabling auto-hibernation Bart Van Assche
2023-08-18 21:11   ` Bao D. Nguyen
2023-08-22  9:20   ` Peter Wang (王信友)
2023-08-22 15:54     ` Bart Van Assche [this message]
2023-08-18 19:34 ` [PATCH v10 14/18] scsi: ufs: sprd: " Bart Van Assche
2023-08-18 21:14   ` Bao D. Nguyen
2023-08-18 19:34 ` [PATCH v10 15/18] scsi: ufs: Rename ufshcd_auto_hibern8_enable() and make it static Bart Van Assche
2023-08-18 21:15   ` Bao D. Nguyen
2023-08-21  5:34   ` Can Guo
2023-08-18 19:34 ` [PATCH v10 16/18] scsi: ufs: Simplify ufshcd_auto_hibern8_update() Bart Van Assche
2023-08-18 21:16   ` Bao D. Nguyen
2023-08-21  5:35   ` Can Guo
2023-08-18 19:34 ` [PATCH v10 17/18] scsi: ufs: Forbid auto-hibernation without I/O scheduler Bart Van Assche
2023-08-18 21:17   ` Bao D. Nguyen
2023-08-21  5:44   ` Can Guo
2023-08-21  7:13   ` Can Guo
2023-08-18 19:34 ` [PATCH v10 18/18] scsi: ufs: Inform the block layer about write ordering Bart Van Assche
2023-08-18 21:19   ` Bao D. Nguyen
2023-08-21  7:15   ` Can Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a97dcd51-07e1-8972-2661-2a1dd0048e91@acm.org \
    --to=bvanassche@acm.org \
    --cc=avri.altman@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=peter.wang@mediatek.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox