* [PATCH] scsi: aic94xx: Add a missing call to kfree
@ 2016-11-19 17:40 Quentin Lambert
2016-11-22 15:51 ` Tomas Henzl
0 siblings, 1 reply; 2+ messages in thread
From: Quentin Lambert @ 2016-11-19 17:40 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel, kernel-janitors
Cc: Quentin Lambert
Most error branches following the call to kzalloc contain
a call to kfree. This patch add these calls where they are
missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/scsi/aic94xx/aic94xx_hwi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/scsi/aic94xx/aic94xx_hwi.c
+++ b/drivers/scsi/aic94xx/aic94xx_hwi.c
@@ -228,8 +228,10 @@ static int asd_init_scbs(struct asd_ha_s
bitmap_bytes = (asd_ha->seq.tc_index_bitmap_bits+7)/8;
bitmap_bytes = BITS_TO_LONGS(bitmap_bytes*8)*sizeof(unsigned long);
asd_ha->seq.tc_index_bitmap = kzalloc(bitmap_bytes, GFP_KERNEL);
- if (!asd_ha->seq.tc_index_bitmap)
+ if (!asd_ha->seq.tc_index_bitmap) {
+ kfree(asd_ha->seq.tc_index_array);
return -ENOMEM;
+ }
spin_lock_init(&seq->tc_index_lock);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] scsi: aic94xx: Add a missing call to kfree
2016-11-19 17:40 [PATCH] scsi: aic94xx: Add a missing call to kfree Quentin Lambert
@ 2016-11-22 15:51 ` Tomas Henzl
0 siblings, 0 replies; 2+ messages in thread
From: Tomas Henzl @ 2016-11-22 15:51 UTC (permalink / raw)
To: Quentin Lambert, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel, kernel-janitors
On 19.11.2016 18:40, Quentin Lambert wrote:
> Most error branches following the call to kzalloc contain
> a call to kfree. This patch add these calls where they are
> missing.
>
> This issue was found with Hector.
Hi Quentin,
most error branches also do set the freed pointer to NULL,
please do the same.
tomash
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
>
> ---
> drivers/scsi/aic94xx/aic94xx_hwi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- a/drivers/scsi/aic94xx/aic94xx_hwi.c
> +++ b/drivers/scsi/aic94xx/aic94xx_hwi.c
> @@ -228,8 +228,10 @@ static int asd_init_scbs(struct asd_ha_s
> bitmap_bytes = (asd_ha->seq.tc_index_bitmap_bits+7)/8;
> bitmap_bytes = BITS_TO_LONGS(bitmap_bytes*8)*sizeof(unsigned long);
> asd_ha->seq.tc_index_bitmap = kzalloc(bitmap_bytes, GFP_KERNEL);
> - if (!asd_ha->seq.tc_index_bitmap)
> + if (!asd_ha->seq.tc_index_bitmap) {
> + kfree(asd_ha->seq.tc_index_array);
> return -ENOMEM;
> + }
>
> spin_lock_init(&seq->tc_index_lock);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-22 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-19 17:40 [PATCH] scsi: aic94xx: Add a missing call to kfree Quentin Lambert
2016-11-22 15:51 ` Tomas Henzl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).