From: Subhash Jadavani <subhashj@codeaurora.org>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Santosh Y <santoshsy@gmail.com>
Subject: Re: [PATCH] ufs: Add missing UFS_MASK macro definition
Date: Thu, 24 Nov 2016 07:07:17 -0800 [thread overview]
Message-ID: <a9dbd99252db26ca6a93c567d978dc2c@codeaurora.org> (raw)
In-Reply-To: <1479963531-6458-1-git-send-email-zhangfei.gao@linaro.org>
On 2016-11-23 20:58, Zhangfei Gao wrote:
> From: Santosh Y <santoshsy@gmail.com>
>
> Reported-by: Venkatraman S <svenkatr@ti.com>
> Reviewed-by: Vinayak Holikatti <vinholikatti@gmail.com>
> Signed-off-by: Santosh Y <santoshsy@gmail.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>
> Find the original patch from
> http://www.spinics.net/lists/linux-scsi/msg58634.html
>
> drivers/scsi/ufs/ufshci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
> index 9599741..bbd8df9 100644
> --- a/drivers/scsi/ufs/ufshci.h
> +++ b/drivers/scsi/ufs/ufshci.h
> @@ -83,6 +83,8 @@ enum {
> MASK_UIC_DME_TEST_MODE_SUPPORT = 0x04000000,
> };
>
> +#define UFS_MASK(mask, offset) ((mask) << (offset))
> +
> /* UFS Version 08h */
> #define MINOR_VERSION_NUM_MASK UFS_MASK(0xFFFF, 0)
> #define MAJOR_VERSION_NUM_MASK UFS_MASK(0xFFFF, 16)
LGTM.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-24 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 4:58 [PATCH] ufs: Add missing UFS_MASK macro definition Zhangfei Gao
2016-11-24 15:07 ` Subhash Jadavani [this message]
2016-11-25 15:05 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9dbd99252db26ca6a93c567d978dc2c@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=santoshsy@gmail.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox