From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 1/5] ata: libata-scsi: Fix ata_mselect_control_ata_feature() return type
Date: Fri, 18 Apr 2025 10:14:25 +0200 [thread overview]
Message-ID: <aAIJ4Za6kKCnY8ik@ryzen> (raw)
In-Reply-To: <20250418075517.369098-2-dlemoal@kernel.org>
On Fri, Apr 18, 2025 at 04:55:13PM +0900, Damien Le Moal wrote:
> The function ata_mselect_control_ata_feature() has a return type defined
> as unsigned int but this function may return negative error codes, which
> are correctly propagated up the call chain as integers.
>
> Fix ata_mselect_control_ata_feature() to have the correct int return
> type.
>
> While at it, also fix a typo in this function description comment.
>
> Fixes: df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
> Cc: stable@vger.kernel.org
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2025-04-18 8:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 7:55 [PATCH v2 0/5] CDL Feature control improvements Damien Le Moal
2025-04-18 7:55 ` [PATCH v2 1/5] ata: libata-scsi: Fix ata_mselect_control_ata_feature() return type Damien Le Moal
2025-04-18 8:14 ` Niklas Cassel [this message]
2025-04-18 7:55 ` [PATCH v2 2/5] ata: libata-scsi: Fail MODE SELECT for unsupported mode pages Damien Le Moal
2025-04-18 8:40 ` Niklas Cassel
2025-04-18 9:30 ` Damien Le Moal
2025-04-18 11:45 ` Niklas Cassel
2025-04-18 23:02 ` Damien Le Moal
2025-04-18 7:55 ` [PATCH v2 3/5] ata: libata-scsi: Fix ata_msense_control_ata_feature() Damien Le Moal
2025-04-18 7:55 ` [PATCH v2 4/5] ata: libata-scsi: Improve CDL control Damien Le Moal
2025-04-18 7:55 ` [PATCH v2 5/5] scsi: " Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAIJ4Za6kKCnY8ik@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox