From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9850A1DE2CC for ; Wed, 11 Jun 2025 18:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749667322; cv=none; b=QPa7IvwhFTtzpHH5dM706VnBHaJGDflwOmX+izzNrpREIC5nJ6oAswq741h3PFvZIs5+jwE158IxdUEmftpuvmnR1Om3HrzAW0rW7ddbkgy/Vm9aymbeoFNmF0RlPtc/41MDQRrzcvobCxmvi30rZ0+4jn2NliBr8I8K3nxOO0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749667322; c=relaxed/simple; bh=CkHxhlfuBpVaK4GXCF8g07K/ObYJP2txf0W3iqQi/X0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q4bSquDPUwUZq+GExxjC4BIbykUZ+c8tINSxTCd1kSbbXSYPLhS5xyYdPqwXk7Q1AeFhz55p8LDN/sDIGWnbKKdkUzNW4zhJmct3U/0TNT7NFYeqLLrW9+Lxb9rjqga/j8794NzwTS5OaFY/FwiD2yO6U9owHWa2qeun9ZYHzk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=f8H2CDZw; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f8H2CDZw" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso219860f8f.1 for ; Wed, 11 Jun 2025 11:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749667319; x=1750272119; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WKfrpUvrdAwcpn30SJ8EKISnxqjztsTWvvkV9uw1jUs=; b=f8H2CDZwlvpmnVM8mlBffYmWjzd3wwn5MySf/i0lnfG+i47UvG09/ma8OreItS1jJ9 bnIEmEJSt38Ehpc4y14TKsPueQ4H+awxjI3AkVhzlWiVmQbZR7H/5JAxL8jJI5cn270b HmyNVGKRyfVazTAf0OI4cAF0FPUyNO0jGq08jnh70BTq3/H8pNByXU/15/Rh+b5AFwAC jjEXytIsVrmu9MXt18Ci432+wrEgDXOy8yb2+QONCz29blACWERrN+1u/ccNLz+9DbUl c5bf5+yUiuuiarPi4ceYHtmu3ZKHQeRIhUmeRFXnTKU9A19d1Mc6p+I+zSBV+W3OjhTM jhqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749667319; x=1750272119; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WKfrpUvrdAwcpn30SJ8EKISnxqjztsTWvvkV9uw1jUs=; b=OMJwJR/Leu8ZLVxpVqyIfiJfL0ilR462TGL1PdgpxXBWsaSLtweUkJjPYwssRH7tOJ ywPt7OEjCHFR8t+VuZOWbcMhDyuzXYXn8RCSR7+SlAow25Ispkbw8HYqCsmkyiZN8j7o 3is3JF/9mKQ+JD3sFAK6KvWwD49arLNTRukpsI7nIj5Wzfu8Drzk4F6ZzTX7r6S7LZU+ x/tb7gZ5l62EyDcVp3bY69kiubbRgy7MAa0wS8AGzmfJzrOBXaY4rFcnDMYahlBwOqyS jIOXXYPw/bpg00T0Mk1Y2YqpVxAo4f0rzbbINmApdNtCsjJ0fTyOPOyC1QlPW3x8Ny7x URLg== X-Forwarded-Encrypted: i=1; AJvYcCWjWDO8RsDOx9jgE7CnnBiE63cTmuOl9e8c1/gTlfR7Zn9lF4pMPloYFiRgQKZJSsoRVOfOhZvwPFG9@vger.kernel.org X-Gm-Message-State: AOJu0YwgnEmXJ/2dcrsiRAKalx8/6gtlaF6keVHnpnzr9Tf0YxUNXiQt JrU9+9zxeIAT/XuEdvksQOTu66HNKBmakB51b2NCmUheIgiyV6WF5wgYwDG435rXR2w= X-Gm-Gg: ASbGncsqVuaLJ4rFO2aYk30rVNiqFXQqrYnXIN1PaJYjQ6kJMyS+xw0de1HZFIWMkKB C4Ag7GMKcLxeX6tQPsc8h0QMeXp4IeD9Pb5G94pwa7BU5jJkXtUNB3wmTPpulEH3eiP8NsqctVy LRZspMl47W9HeqNMp4LaJCSofWj9ZaQZlHYEySnZlDTv4P3qQSzqCuKKg2p3iSEQH6yBPn341pV 5TY8+3Iik2jXrAmSWOMsqzvX7YZkHSKVcLF1jMEZXPpCeCNwy3pN9Ymw5vNrPrrNK0oI7qrMIWp lAfCLl/DM5RQM9bUzlZ/64TSjDJC+2muUk13kauAHdK9nbblabQn92BS04eCqU0ejs0= X-Google-Smtp-Source: AGHT+IE8IO3x5kgMMLjG88ZEq35UY3RD1TsJ71KI+PrQeFiKWv1nPP47wXf32YYs9T5iAq6yC36tgA== X-Received: by 2002:a05:6000:2207:b0:3a0:b940:d479 with SMTP id ffacd0b85a97d-3a560809a92mr423897f8f.53.1749667318953; Wed, 11 Jun 2025 11:41:58 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a53229dc33sm15903289f8f.20.2025.06.11.11.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 11:41:58 -0700 (PDT) Date: Wed, 11 Jun 2025 21:41:55 +0300 From: Dan Carpenter To: Karan Tilak Kumar Cc: sebaddel@cisco.com, arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com, mkai2@cisco.com, satishkh@cisco.com, aeasi@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jmeneghi@redhat.com, revers@redhat.com Subject: Re: [PATCH 2/5] scsi: fnic: Fix crash in fnic_wq_cmpl_handler when FDMI times out Message-ID: References: <20250611183033.4205-1-kartilak@cisco.com> <20250611183033.4205-2-kartilak@cisco.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250611183033.4205-2-kartilak@cisco.com> On Wed, Jun 11, 2025 at 11:30:30AM -0700, Karan Tilak Kumar wrote: > When both the RHBA and RPA FDMI requests time out, fnic reuses a frame > to send ABTS for each of them. On send completion, this causes an > attempt to free the same frame twice that leads to a crash. > > Fix crash by allocating separate frames for RHBA and RPA, > and modify ABTS logic accordingly. > > Tested by checking MDS for FDMI information. > Tested by using instrumented driver to: > Drop PLOGI response > Drop RHBA response > Drop RPA response > Drop RHBA and RPA response > Drop PLOGI response + ABTS response > Drop RHBA response + ABTS response > Drop RPA response + ABTS response > Drop RHBA and RPA response + ABTS response for both of them > > Reviewed-by: Sesidhar Baddela > Reviewed-by: Arulprabhu Ponnusamy > Reviewed-by: Gian Carlo Boffa > Tested-by: Arun Easi > Co-developed-by: Arun Easi > Signed-off-by: Arun Easi > Tested-by: Karan Tilak Kumar > Signed-off-by: Karan Tilak Kumar > --- This needs a Fixes tag and a CC to stable. regards, dan carpenter