From: Chris Leech <cleech@redhat.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-scsi@vger.kernel.org, Nilesh Javali <njavali@marvell.com>,
Kees Cook <kees@kernel.org>, Bryan Gurney <bgurney@redhat.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
John Meneghini <jmeneghi@redhat.com>
Subject: Re: [PATCH v2 1/1] scsi: qla2xxx: replace non-standard flexible array purex_item.iocb
Date: Tue, 29 Jul 2025 17:04:58 -0700 [thread overview]
Message-ID: <aIlhqnjTI_7K-Iws@my-developer-toolbox-latest> (raw)
In-Reply-To: <6d8f13c8-405f-4fa0-ad23-09c9e4c5cd54@embeddedor.com>
On Mon, Jul 28, 2025 at 08:20:12PM -0600, Gustavo A. R. Silva wrote:
>
> I just noticed that the new TRAILING_OVERLAP() helper just landed in
> Linus' tree, and this issue seems to be a perfect candidate for it.
>
> The (untested) patch below avoids the use of `struct_group_tagged()`
> and the casts to `struct purex_item *`:
(I was largely basing my use of struct_group on your blog post from a
few month back, but now there's another new macro!)
Yes, that looks like it would work as long as the driver maintainer
doesn't object to moving that field around in scsi_qla_host.
I'm getting ready to be away from the computer for a week, so I have to
leave this for now. Maybe Nilesh has an opinion?
- Chris
next prev parent reply other threads:[~2025-07-30 0:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 21:27 [PATCH 0/2] scsi: qla2xxx: flexible array / field-spanning write issue Chris Leech
2025-07-25 21:27 ` [PATCH 1/2] scsi: qla2xxx: replace non-standard flexible array purex_item.iocb Chris Leech
2025-07-25 21:54 ` Kees Cook
2025-07-28 18:57 ` [PATCH v2 1/1] " Chris Leech
2025-07-28 19:43 ` Gustavo A. R. Silva
2025-07-28 19:54 ` Gustavo A. R. Silva
2025-07-28 21:15 ` Chris Leech
2025-07-28 22:55 ` Gustavo A. R. Silva
2025-07-28 23:52 ` Chris Leech
2025-07-29 1:37 ` Gustavo A. R. Silva
2025-07-29 2:20 ` Gustavo A. R. Silva
2025-07-30 0:04 ` Chris Leech [this message]
2025-07-30 1:33 ` Gustavo A. R. Silva
2025-07-30 3:44 ` Gustavo A. R. Silva
2025-07-30 15:43 ` Bryan Gurney
2025-07-30 20:55 ` Gustavo A. R. Silva
2025-07-25 21:27 ` [PATCH 2/2] scsi: qla2xxx: unwrap purex_item.iocb.iocb so that __counted_by can be used Chris Leech
2025-07-25 21:56 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIlhqnjTI_7K-Iws@my-developer-toolbox-latest \
--to=cleech@redhat.com \
--cc=bgurney@redhat.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=jmeneghi@redhat.com \
--cc=kees@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox