From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98DA12D0C8E for ; Wed, 13 Aug 2025 05:49:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755064155; cv=none; b=dhFP8z3GJ50ktAA58YmDSEVJxZGoGWnDPcPAORslT/JiXMR/IG3yM6wrqS6yh7LlhcFrE4oTWDg8uvHnHCp/br8bsvCpwQ00F4K9IlXGNPzUCm8Jkf+quSA7g5koaO+l4En4KLyhR5qFPvVra38XMJk8Isjg5ri1GNRzrLmqYUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755064155; c=relaxed/simple; bh=5XEzjMGKnaeMJFhQb3Nwzbat+idzevLzr/emeLMFnok=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Drqic3y1WSI4NibVb/bzzZB+vHg547wn1RtZ2AsXfDJZzA5RPacZAMwLazW4Z3BRDQn4QIEJbKbvR87DpU95eVY8FcBF7LVx6Z7M0RlPzW27MEDNlMq0Zkjkt9KJHtlEFas7rmRE0TjeUxbDBGpU4puRbVCdQ//VXdU4WvNMnXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MmliNpgi; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MmliNpgi" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3b913a76ba9so1204933f8f.3 for ; Tue, 12 Aug 2025 22:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755064152; x=1755668952; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=1NATFWYnL9FpvCQHaSEVWqiysmgBFz5wmTJhKI3JDuA=; b=MmliNpgiE/VmRLHxzAL0+iYkaLFqIm9XMYYpGoXkcCzDp1VE3K+5MqRTwqY2MKT0Q9 UYnD9ZkOVjPAp4HTLJhXxtFsHVPDPteUtVL/XEwK3O76gkIdu9eIPT8chZnbMMee3UDe kgfaTZBLJdvKhFVU6dosQTRlRlIFc912tK4LVFnWyAw6pZtbi0yQDPY1v1ISCAOfI7qI c53Ibvhg6ZSTjr9Rh/495y5pbY4h6pNnxfBCweBdFFFAXJgmYckQe62/un09B3tv8zBJ TV+9qAhEu1s+WIJTCdJkixR601r0p2yuSpfkuLxbJuhRu6RFSnVIe+O+Zd+YqWP+xh4I 38fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755064152; x=1755668952; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1NATFWYnL9FpvCQHaSEVWqiysmgBFz5wmTJhKI3JDuA=; b=WwcPeugRfza/b5VC2vqqziU+4/1bjIMrmr8HaZ03mpJ2WdcYCZvFcQwpv4EL2nWtuS oH/gaz0ers0sKNBLago2X1Ig4OTWCNGGnfNoj4x+7Ak1Yaz9Veg6mTxfMOylYhfqKoWk tLGgP3MAW84sKFjaWgq6W5zTuVqlUdaZOHZiVa0zakReB3H1M9vz6QtNuzqKZPXfTyeI m4yxpDxfMdhWtxJSojuhdIkHOstJZRXC6/r+7u4FJMQ2j8S7PA52Xej8zix8bl3Sik2z 6m8s7eESV5CivawP4QjTUN3nGIL1odw005SrtwVK1pcrIc8Hbh+ZC3dAqCGXz6lYZltS WuXw== X-Forwarded-Encrypted: i=1; AJvYcCXtU0BT0Dde+29OWybp92FTXm7tIfEAePLrNJ+m5Or/pyinW3tZT9pVYCXvCzvlqJ5JNb9DiEZJnOVP@vger.kernel.org X-Gm-Message-State: AOJu0YwnbsByOE9TYw7D1o9IiR4orzCV+t1E05eoIOX5YXXmGLy7Gdxs 1ctSMfiw3b4a0OL896f0p/TqKDHI5YPd7U34eYC5Mw0z4pLwFpB+ckTMSr0Ym+dtH8U= X-Gm-Gg: ASbGnctI4cPEzrB69j8xWF6MNm4cakEuQklvk9clUhM49ZLHPY+2L4Vws4qn8w3M0n9 rdkrIV9ngpe7KJHQ9WAXN+jREmgDuDJI+Cg8iZSH/sLgVdmj69l0IpJ1p4k94EmCwWp9U/pu7B5 C1WtE6R/hxjBkn79OiUL3NLCPSuKU/YuVBQADzLG8bxfsUVk7wxRNV9qzMgMTtma9SB9CqfPZuZ VoFS/Ql6GxnnxDmJJD3KPi0eCXzQ1WEqkCgKXG5mu/RzEGDmKXd2CBXHIpJrfqtbcyMscSMXCtg +FeztWo7BEG36DyIfZSTXXVRAbXm+z/5dLqHiHzCL9gih/GYgwa7LY3doXPYK2XfmaLNKwaZzCJ y11F5h5RbpqiI3D/29JMdO7pw4TY0NM1fK/vkAQ== X-Google-Smtp-Source: AGHT+IFDvLxnIU17Hp8mu8s/hfxqo91PU/ydIDKmiqnIJjDK4g9R/0BJmMQ3yTeiQ09ZscNds3uIlA== X-Received: by 2002:a05:6000:4205:b0:3b8:d493:31f4 with SMTP id ffacd0b85a97d-3b917eb6c5bmr1136780f8f.48.1755064151797; Tue, 12 Aug 2025 22:49:11 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b79c4696c8sm45376480f8f.55.2025.08.12.22.49.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 22:49:11 -0700 (PDT) Date: Wed, 13 Aug 2025 08:49:08 +0300 From: Dan Carpenter To: Mike Christie Cc: Nilesh Javali , Manish Rangankar , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , "Martin K. Petersen" , James Bottomley , Ravi Anand , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] scsi: qla4xxx: Prevent a potential error pointer dereference Message-ID: Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The qla4xxx_get_ep_fwdb() function is supposed to return NULL on error, but qla4xxx_ep_connect() returns error pointers. Propagating the error pointers will lead to an Oops in the caller, so change the error pointers to NULL. Fixes: 13483730a13b ("[SCSI] qla4xxx: fix flash/ddb support") Signed-off-by: Dan Carpenter --- drivers/scsi/qla4xxx/ql4_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index a39f1da4ce47..a761c0aa5127 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -6606,6 +6606,8 @@ static struct iscsi_endpoint *qla4xxx_get_ep_fwdb(struct scsi_qla_host *ha, ep = qla4xxx_ep_connect(ha->host, (struct sockaddr *)dst_addr, 0); vfree(dst_addr); + if (IS_ERR(ep)) + return NULL; return ep; } -- 2.47.2