Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: David Wang <00107082@163.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	phil@philpotter.co.uk, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	James.Bottomley@hansenpartnership.com,
	martin.petersen@oracle.com
Subject: Re: [BUG] general protection fault when connecting an old mp3/usb device
Date: Wed, 20 Aug 2025 21:06:23 +0100	[thread overview]
Message-ID: <aKYqvyfSO-jSTZAr@equinox> (raw)
In-Reply-To: <7c8215f8.87f8.198c6edb9f0.Coremail.00107082@163.com>

On Wed, Aug 20, 2025 at 06:02:05PM +0800, David Wang wrote:
> 
> >Phillip, is this behavior perhaps introduced by commit 5ec9d26b78c4
> >("cdrom: Call cdrom_mrw_exit from cdrom_release function")? Please do
> 
> I manage to reproduce this, but It turns out this is not about my old mp3 device, but about my phone:
> Just connect-umount-discnnect, and repeat, after several rounds, an error log would show up.
> (I should pay attention to the USB Product  name in log......
> It is just that I check the log only when I have trouble  connecting my mp3 device, and assuming the log is about my mp3 device.)
> 

Interesting. It seems your phone is emulating a CD-ROM/optical device,
which is why the driver is being loaded and attached to it.

> 
> 
> And after I upgrade to 6.17-rc1, it could not be reproduced ( I managed to test 10+ rounds of connect/umount/disconnect cycle)
> So I think commit 5ec9d26b78c4 does fix my problem.
> 
> Thanks
> David
> 
> >Bart.

Yes, as you point out, this commit became part of 6.17-rc1 - it was not
present in 6.16.0. It actually removes the cdrom_mrw_exit call from the
module unregistration function, and puts it in cdrom_release instead.

This seems to have helped with the original issue - that of crashes when
removing USB optical drives on Chromebooks, and has likely helped here
for the same reason. Good to hear, and thanks for testing/confirming
that 6.17-rc1 has helped.

Regards,
Phil

      reply	other threads:[~2025-08-20 20:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18  9:50 [BUG] general protection fault when connecting an old mp3/usb device David Wang
2025-08-19 19:20 ` Bart Van Assche
2025-08-20  1:38   ` David Wang
2025-08-20 10:02   ` David Wang
2025-08-20 20:06     ` Phillip Potter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKYqvyfSO-jSTZAr@equinox \
    --to=phil@philpotter.co.uk \
    --cc=00107082@163.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox