[PATCH] scsi: scsi_devinfo: blacklist HPE/DISK-SUBSYSTEM

[PATCH] scsi: scsi_devinfo: blacklist HPE/DISK-SUBSYSTEM

[Xose Vazquez Perez]

DISK-SUBSYSTEM is a special model name returned when LUs are not installed
in "OPEN-" models. Full info: https://marc.info/?l=linux-scsi&m=125424006417825

Cc: Ewan D. Milne <emilne@redhat.com>
Cc: Anthony Cheung <anthony.cheung@hpe.com>
Cc: Takahiro Yasui <takahiro.yasui@hitachivantara.com>
Cc: Matthias Rudolph <Matthias.Rudolph@hitachivantara.com>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: SCSI-ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 78346b2b69c9..b39019f57db6 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -185,6 +185,7 @@ static struct {
 	{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
 	{"HP", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
 	{"HPE", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES},
+	{"HPE", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
 	{"IBM", "AuSaV1S2", NULL, BLIST_FORCELUN},
 	{"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 	{"IBM", "2076", NULL, BLIST_NO_VPD_SIZE},
-- 
2.51.0

Re: [PATCH] scsi: scsi_devinfo: blacklist HPE/DISK-SUBSYSTEM

[Xose Vazquez Perez]

On 10/4/25 4:54 PM, Xose Vazquez Perez wrote:

Same here, any problem/drawback?

> DISK-SUBSYSTEM is a special model name returned when LUs are not installed
> in "OPEN-" models. Full info: https://marc.info/?l=linux-scsi&m=125424006417825
> 
> Cc: Ewan D. Milne <emilne@redhat.com>
> Cc: Anthony Cheung <anthony.cheung@hpe.com>
> Cc: Takahiro Yasui <takahiro.yasui@hitachivantara.com>
> Cc: Matthias Rudolph <Matthias.Rudolph@hitachivantara.com>
> Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: SCSI-ML <linux-scsi@vger.kernel.org>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>   drivers/scsi/scsi_devinfo.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> index 78346b2b69c9..b39019f57db6 100644
> --- a/drivers/scsi/scsi_devinfo.c
> +++ b/drivers/scsi/scsi_devinfo.c
> @@ -185,6 +185,7 @@ static struct {
>   	{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
>   	{"HP", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
>   	{"HPE", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES},
> +	{"HPE", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
>   	{"IBM", "AuSaV1S2", NULL, BLIST_FORCELUN},
>   	{"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
>   	{"IBM", "2076", NULL, BLIST_NO_VPD_SIZE},

Re: [PATCH] scsi: scsi_devinfo: blacklist HPE/DISK-SUBSYSTEM

[Christoph Hellwig]

On Sat, Nov 22, 2025 at 11:16:47PM +0100, Xose Vazquez Perez wrote:
> On 10/4/25 4:54 PM, Xose Vazquez Perez wrote:
> 
> Same here, any problem/drawback?

The could be asked the other way around.  What serious enough problem
are you trying to fix that warrants bloating the devinfo lists?

Re: [PATCH] scsi: scsi_devinfo: blacklist HPE/DISK-SUBSYSTEM

[Xose Vazquez Perez]

On 11/24/25 3:06 PM, Christoph Hellwig wrote:

> On Sat, Nov 22, 2025 at 11:16:47PM +0100, Xose Vazquez Perez wrote:
>> On 10/4/25 4:54 PM, Xose Vazquez Perez wrote:
>>
>> Same here, any problem/drawback?
> 
> The could be asked the other way around.  What serious enough problem
> are you trying to fix that warrants bloating the devinfo lists?
> 

This entry was originally covered when "HP" was used as a prefix, as seen in
(add HP DISK-SUBSYSTEM device, for HP XP arrays)
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f96f42b76e00e2871033745ff029056cc725c76

However, after (fixup string compare: ... Vendor strings must match exactly)
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b8018b973c7cefa5eb386540130fa47315b8e337
the "HP" entry no longer covers devices reporting as "HPE".

This patch simply restores the intended behavior for the newer "HPE" vendor string.


Thanks.


[ This thread is almost six months old, for reference:
https://lore.kernel.org/linux-scsi/20251004145459.58259-1-xose.vazquez@gmail.com/ ]