From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30AC62EC579 for ; Thu, 11 Dec 2025 05:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765432173; cv=none; b=a08+MkLC7nM2l0Bj76KaonsMENzHCuViIJA0kOLdgPdMQmyEEbCNsvwB0UMV0kN6aRslpD6Mm7DXV5bERmOP2aan3KnJEEUG9MljAggeL7nr+O6yCNX0Pdf1eoS4VJ+yeRLNZEcgICGZ/lkaYrSNTNl3jwCGz1KZcIuoDfUexUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765432173; c=relaxed/simple; bh=bAeD0Df47bVIpMyfpJVrdazkL7WYvmWPlKz1+De1FAA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jqq+RB4fiqmLsqzTa91e4fLtLNzKCKD+wVyfFkA4RWXaqQvmB6HQSgvMIJVocoCmmkM6qZguy3bYGHpJBOfzESFi2WvCKJ0LVHLZwOq1f8Vysir51VkDsx0VObrHQo+V16ZGKKF/rGbWz4Jkdi6K6CdOFu6E3Ur3T6/ZUA/9FXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mQty6PZy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=E7XepjUC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mQty6PZy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="E7XepjUC" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BALPs783736573 for ; Thu, 11 Dec 2025 05:49:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=NwyN8IJrNXD8SoIBZWx8SQJH zGoai58glbBN4mO9RRU=; b=mQty6PZylh5P19Ykm1FX0n+Qt7Zjnp7CMRUin7MB FBtOa8IDRJfZl2/KtP3kR0pBUeySHvIk5nhdgCm1OcIp2StzibFdyaqMxmifYwms zPN8BSMmAY5oY3lR08aYJlef2OWpaJS6N81sWjxlJ0DWLhKA6nWkz522VjM16Fix VVtwSIXyGGWKefTRKO17Bm5gINW7U3txjtJZeem0mBO1HdhGYz7M1NYMGpfsYZfW 3K0rIy/Z28UZ8zlTuR08d4gqcYC2XpbgMmqt98O02P/muB6xuHkaoDIGzFVf/EqW VlvOnJsKW30JTDfS7kF785XElzxNXBjNQehp9UI36cH7Wg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ayg0ps9dm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Dec 2025 05:49:31 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-34a907477b3so974311a91.2 for ; Wed, 10 Dec 2025 21:49:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765432171; x=1766036971; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NwyN8IJrNXD8SoIBZWx8SQJHzGoai58glbBN4mO9RRU=; b=E7XepjUCgouvlH7XQF8MbZgIsdTgaT4AL8o9D+L25y/G9f172giRjfOYJgJ5Zf6V00 DtVI4gmGvx1dxZTeVXnjvuOc051jhZPV34LiE4Zwsn/iAGFYHnO+VfIbfYjNSPwhtkof zSFfr1u5yo/ujojHwoMQIMiRsh6NRKf6qlCrv19wVWDy/nOkioXD7MK5FLoGqXbVd+3E CcnLTPWrIHOt4/gFAgK6+wfBlwZrGhYUUOy6kel/XT6ODGOls5eAn14jPmcwC/pmABCp JmjiSR+Wf6A98x5YgdxWX6vRdLiOffRxqxnpUDHhJu5h2IfgrnOtVz/dhYkH9KkLT15G iqYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765432171; x=1766036971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NwyN8IJrNXD8SoIBZWx8SQJHzGoai58glbBN4mO9RRU=; b=rmUPzSy3VPVMFUZahESpHfG/qIufizPT9Qo7LPsV3KRPVTzECoJkbh2zkcn1afQUZO Yk+zUNxAmuLz6VaZgoh8SeClpoqVV185lQaquBg4O45yWTj1Gi5a/0XxlwBPysxqaWz9 vGg296FPBj1a3kpx+tu3oA4rIo5BIPg8/X52jw9bAGCWdXFLLEAWhnhpiU45JvjAYgyR y6wNvcV1PylJKOz7rGBD7xGMlCJ15C0fZSMvvASNNHO5pqo1QqQ8EkdUJBS8ZKR8n/fF 2847xYfBMCM5VEhbxnRtyt9/p9kOK+O0ra6JnqmPfZafcW3W2VhmcISjAR972AmH4unj ngAg== X-Forwarded-Encrypted: i=1; AJvYcCU+s6nE3o5vUKreONhpSRBeCEf++dYge13r21tlQacnTtKWoKpn40lX11TB2DIydThtOZV0Y+DjEmiv@vger.kernel.org X-Gm-Message-State: AOJu0YxryHEhje+CffdPrwK44sc8e3GIHl3xzgzHHVBNhiO+b1Jmjv9m Yj0ja6+qw4++nacR2daKmMQkb0WaByPtvubrZssySHLaro9F34RS5Ib4/psP6LHxIgdXjKaFhS+ FrSSHfEDBZpJ9+ZzTwtP+4ESx3Vyu+C57Hy0Cm+paltw3mkWsN6mIxIRhQ28nEpRx X-Gm-Gg: AY/fxX5gpS67EXOt/gfTocrhBk7wdeNFhSuS2az3TW1XvogyuYMWWfKMcwIPBSgOpZb H84y+2Ogxy4lDClgElaHZMMc5g6ZM8hQklyMYBxStQvhSqUfezvrhPK71NPw/dZw2Kw1wT/TPST 1BPxSFHSBtdDZ1oOVF24bGmB4LsYa25q3FyKWiNJ/NdqeXxsOUYBF13u/r9lO3q6SCLt+9Tl+Rj pfzV9r6Y+yC1jqmE8QgjjmPjcUPqv82sPMvOQoNsGa5vYcIKZ8a8QF041eEulTlpp8ROXCdXpHw dRvTkly8JCMGate2d1XbtQGslUH3v5xKLWL6ybS7D99GnStk3NADLjqsU068H5aOorZ3RRJToZK 52+6OvRlAJEViCZuIYFgofpGighFB+JrMLk1SZQesn4+2VG0= X-Received: by 2002:a17:90a:ec8b:b0:341:194:5e7c with SMTP id 98e67ed59e1d1-34a72838633mr4381154a91.24.1765432170715; Wed, 10 Dec 2025 21:49:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+DfS4aFflmDkMLyhdNowrZaC/gdIB2g+zo9uoNkqehdTHMx4/Ak+zelKEffLx/D2RWL7Beg== X-Received: by 2002:a17:90a:ec8b:b0:341:194:5e7c with SMTP id 98e67ed59e1d1-34a72838633mr4381130a91.24.1765432170254; Wed, 10 Dec 2025 21:49:30 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34a9275474asm713481a91.16.2025.12.10.21.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 21:49:29 -0800 (PST) Date: Thu, 11 Dec 2025 11:19:24 +0530 From: Abhinaba Rakshit To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v2 1/3] soc: qcom: ice: Add OPP-based clock scaling support for ICE Message-ID: References: <20251121-enable-ufs-ice-clock-scaling-v2-0-66cb72998041@oss.qualcomm.com> <20251121-enable-ufs-ice-clock-scaling-v2-1-66cb72998041@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: vywsMNJOtmIh6-9MgbSHKdnn2ZlD6cya X-Authority-Analysis: v=2.4 cv=b46/I9Gx c=1 sm=1 tr=0 ts=693a5b6b cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=SuTxBroE--coa4UUL8EA:9 a=CjuIK1q_8ugA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjExMDAzOSBTYWx0ZWRfXwC0wFoUjDgFa ttiFW3FvOX7nY8lGKJLc8YhAPhSqflbp/JYsXfWjeSXr2m1VRmwSs2GDxEqTfgG5l89B0MaI+t7 P78SLoC5cIH1nmdVfWLc2PF+ewTP1fwDYIQMleAZ8kcu+7ZkWa011Hee90cdHWq7HeJPbjYpUZW G3UcpChAXl+GhMp+VjlSL5gyYqhILEtUDQXsYMTgDjPQv48V0KwQDlv8Lgd+O4EbXyLAPqwkhh5 HepHxBUs957+Yh0VK0CagUXSfrXbLYZ4XfdapEEt9L8MJtiDxCfbLf8quAeQvcQYD7enu9JHwBX P55Yqgt+5bIM6gTZ5IzPTmXBJ67LAHbQ3qFtPo0n6b+O+XEhwRS1AGla7pKDTdbcT92XkSZOzCI 3kDufw1AuTl0TMyNCvriBS9jTOvIiA== X-Proofpoint-GUID: vywsMNJOtmIh6-9MgbSHKdnn2ZlD6cya X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-10_03,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512110039 On Fri, Nov 21, 2025 at 02:46:52PM +0100, Konrad Dybcio wrote: > On 11/21/25 11:36 AM, Abhinaba Rakshit wrote: > > Register optional operation-points-v2 table for ICE device > > and aquire its minimum and maximum frequency during ICE > > device probe. > > > > Introduce clock scaling API qcom_ice_scale_clk which scale ICE > > core clock if valid (non-zero) frequencies are obtained from > > OPP-table. Zero min and max (default values) frequencies depicts > > clock scaling is disabled. > > > > When an ICE-device specific OPP table is available, use the PM OPP > > framework to manage frequency scaling and maintain proper power-domain > > constraints. For legacy targets without an ICE-device specific OPP table, > > fall back to the standard clock framework APIs to set the frequency. > > You can still set a frequency through OPP APIs if the table is empty > (and one is always created even if devm_pm_opp_of_add_table() fails) > > [...] > > > /* > > * Legacy DT binding uses different clk names for each consumer, > > - * so lets try those first. If none of those are a match, it means > > - * the we only have one clock and it is part of the dedicated DT node. > > - * Also, enable the clock before we check what HW version the driver > > - * supports. > > + * so lets try those first. Also get its corresponding clock index. > > + */ > > I would argue *not* setting the rate on targets utilizing a binding without > an OPP table for the ICE is probably a smart thing to do, because we may > brownout the SoC this way Also, adding to the previous reply, if we completly remove clock scaling for any target we see a major degradation in IO throughput. On targets like Talos (target with legacy binding), we observed around ~50%-70% degradation of IO performance if we don't keep the ICE clock on par with storage clock and leaving it operate at default frequency. > > Konrad