[PATCH] scsi: qla2xxx: Completely fix fcport double free

[PATCH] scsi: qla2xxx: Completely fix fcport double free

[Vladimir Riabchun]

In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free.
When an error happens, this function is called by qla2x00_sp_release,
when kref_put releases the first and the last reference.

qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport.
Doing it one more time after kref_put is a bad idea.

Fixes: 82f522ae0d97 ("scsi: qla2xxx: Fix double free of fcport")
Fixes: 4895009c4bb7 ("scsi: qla2xxx: Prevent command send on chip reset")
Signed-off-by: Vladimir Riabchun <ferr.lambarginio@gmail.com>
Signed-off-by: Farhat Abbas <fabbas@cloudlinux.com>
---
 drivers/scsi/qla2xxx/qla_iocb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 3224044f1775..0de015de7eb5 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -2751,7 +2751,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (!elsio->u.els_logo.els_logo_pyld) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
@@ -2776,7 +2775,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (rval != QLA_SUCCESS) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
-- 
2.43.0

Re: [PATCH] scsi: qla2xxx: Completely fix fcport double free

[Vladimir Riabchun]

Friendly ping.

Best regards,
Riabchun Vladimir

Re: [PATCH] scsi: qla2xxx: Completely fix fcport double free

[Martin K. Petersen]

Nilesh,

> In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free.
> When an error happens, this function is called by qla2x00_sp_release,
> when kref_put releases the first and the last reference.
>
> qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport.
> Doing it one more time after kref_put is a bad idea.

Please review!

  https://lore.kernel.org/all/aYsDln9NFQQsPDgg@vova-pc/

-- 
Martin K. Petersen

RE: [EXTERNAL] [PATCH] scsi: qla2xxx: Completely fix fcport double free

[Nilesh Javali]

From: Vladimir Riabchun <ferr.lambarginio@gmail.com> 
Sent: Tuesday, February 10, 2026 3:38 PM
To: Nilesh Javali <njavali@marvell.com>
Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>; James.Bottomley@hansenpartnership.com; martin.petersen@oracle.com; Saurav Kashyap <skashyap@marvell.com>; himanshu.madhani@oracle.com; Quinn Tran <qutran@marvell.com>; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [EXTERNAL] [PATCH] scsi: qla2xxx: Completely fix fcport double free

In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free. When an error happens, this function is called by qla2x00_sp_release, when kref_put releases the first and the last reference. qla2x00_els_dcmd_sp_free frees fcport by
ZjQcmQRYFpfptBannerStart
Prioritize security for external emails: 
Confirm sender and content safety before clicking links or opening attachments 
  https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!s23TuNc6Kf4b28FwlfU2YPVqCLYs7V92y9zVWZhLT6LLyCdQdVjtn_gEpzNAiNXoB4Y$  ‌ 


ZjQcmQRYFpfptBannerEnd
In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free.
When an error happens, this function is called by qla2x00_sp_release,
when kref_put releases the first and the last reference.

qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport.
Doing it one more time after kref_put is a bad idea.

Fixes: 82f522ae0d97 ("scsi: qla2xxx: Fix double free of fcport")
Fixes: 4895009c4bb7 ("scsi: qla2xxx: Prevent command send on chip reset")
Signed-off-by: Vladimir Riabchun <mailto:ferr.lambarginio@gmail.com>
Signed-off-by: Farhat Abbas <mailto:fabbas@cloudlinux.com>
---
 drivers/scsi/qla2xxx/qla_iocb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 3224044f1775..0de015de7eb5 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -2751,7 +2751,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (!elsio->u.els_logo.els_logo_pyld) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
@@ -2776,7 +2775,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (rval != QLA_SUCCESS) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
-- 
2.43.0

Reviewed-by: Nilesh Javali <njavali@marvell.com>

Re: [PATCH] scsi: qla2xxx: Completely fix fcport double free

[Martin K. Petersen]

On Tue, 10 Feb 2026 11:08:22 +0100, Vladimir Riabchun wrote:

> In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free.
> When an error happens, this function is called by qla2x00_sp_release,
> when kref_put releases the first and the last reference.
> 
> qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport.
> Doing it one more time after kref_put is a bad idea.
> 
> [...]

Applied to 7.0/scsi-fixes, thanks!

[1/1] scsi: qla2xxx: Completely fix fcport double free
      https://git.kernel.org/mkp/scsi/c/c0b7da13a04b

-- 
Martin K. Petersen