From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E5F138B7A1 for ; Thu, 26 Feb 2026 06:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772086453; cv=none; b=Xedf3Q+ANqkuQUvScpPXi4ldLEfTV310+ETMussL9l/tfT/fD/VN3FFQCetPGek1Z5/0FoCRRXEGjS+sLl5QAcm0wS2Mnu5uZ+sS1805D+pyATL6axK0emqmQrNlwbmo72V2igqpSDV9usbjsaoct21fFY8Lxu8uS+sKngvEnj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772086453; c=relaxed/simple; bh=m+AQKCxO/LycJ/O9uPJYO7qZo0j4nsAa3IseTsVVrv4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AoMhMs9o3cHsWYwffqXSRH8G2Z5m96bvyGDAumnH7HQzRmXeQ1KYcFEsuLjWWRYEE6WqdPmEFAi6j57eF/iDiFdFoaW+A/9o7bsnd/7aeF6bwco454gcfCO43khSOx9A6gwAi4mEHYJVLSDNgLyYM9IoIGvUkHu/QvOYCwyMcOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ms86ZEQt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YNjszvZ+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ms86ZEQt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YNjszvZ+" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61Q4UpVf3225922 for ; Thu, 26 Feb 2026 06:14:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=bhxKk2mKAOrKAUcO1cv8XTYS PnL0KRsykixJVQdAXmk=; b=ms86ZEQtx5mYD+GDtgkhR+/7q8PT+AwHsekfG00Y Gni4JgNzCXKdB+MkiLr4s1ymi5A6T1q7JrL0SNwCsYfpyjx640ZPE//Fmoz7RfH8 IpBLb1ur0rZNymlpu43EjTzqp9ra8ov4ZsuPUmYAtWgwApzMkLyPL9Q7riBXQsJ4 J3/Xiu5O6PkbSIy3HGWwyDirIUlsYU0Zo9JPnnNRRQeCCkWCDdYvkctxADQfXlEc Ct36PxQoWeiY+pr3p/A6OaqGhQgRdTLtqOu9JhtheEaO8tNcwRkRzxS/KhgfZTy7 wEmi6Uzv2ktjfkEeSz9V6UcyNXONJEHBL9pYg5sT9dMMGw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cjdph0ga6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Feb 2026 06:14:11 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2adaa9c4b89so16940475ad.0 for ; Wed, 25 Feb 2026 22:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772086450; x=1772691250; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bhxKk2mKAOrKAUcO1cv8XTYSPnL0KRsykixJVQdAXmk=; b=YNjszvZ+/QjbY8k2K7QQWgnUAwizypUnf+vz4QdjHSjGDqX5YedDcenjR3G/tAXF0y 9jBftewn3/VRWw1GTUYN8QUoQQyZ7kw6J5vLAlaUlE2ctdYPSDsG50a6FbBIbTbhOlXx 1xbiZNScr+haTy5k71mxq3R1m6fdYMRRJ/xG37Zj1t69S+Dz2a7UaZVpy2WtLyNN4Scy 7CKJhx8O4dCKakRZ126VEYFMIkJTrzoO5vqTQYtFuYecpdcQOeXP6ETjVeF7ffmHeUqh 7fT/+pA4/CfIM7OK3ylJZ5Q5185rkA5uvwV3ZCLrY7fUzI9KTL5cBiuGjtbVG39S0+7L tX3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772086450; x=1772691250; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bhxKk2mKAOrKAUcO1cv8XTYSPnL0KRsykixJVQdAXmk=; b=ORkQGeVm+kFbkCfCvPgEpAXVvMkSZ32XFobyxNKWtXuL5gjfyKiqqF8hZk8EGv6hj9 ZcFLqrBJFukO8lY8fcdg5/noRIR7JNYaamGsg83hua+S0stTjFMkOTUkdrz2KQPQbive /Fm83A9D1M8J15qE6CXqZ5AlJDpTMKlzgW7aHyVTGbinsbROHYeRlRInavF2Pmgcaqdw ZwJvY5zSsjZwk2G9zhzJkPsQ2waoF/i4ZdY8/Azq6BUuWsBrMR+kRIc66oZKhxAHdrfP 1HiKCQpqosm2GwaHCaNvPT8Ae7crEEXDP16HRxafvXhmTOWVB4iYSkVYK/7x8yVEFImp Nl4A== X-Forwarded-Encrypted: i=1; AJvYcCXfNXSlvqf+zNlltdTI0koI7K8WJ/CvHTCu7ZEC/p3kug6yE4HR1war4Dt7NPy3xGjwvFOZ5YP4CfMg@vger.kernel.org X-Gm-Message-State: AOJu0YxzCNveSq5HGSmV2fwn6UdQ9Ns/N6vAcbXxW43qVly0Bhj3PzRR dluhhq07NtV7XZkdjG9fuZO2dfBk9D3Ku+AAU/ngI12gxY41gtRuIEJ94llxWrIPSUu3ICDm6lr 8nFAjrsB5aDJfZSP9gNDoxqDOLrs60KLNotmCA72LyMyOAOT1751im6dSav3bb1np X-Gm-Gg: ATEYQzzNrRRsu+8qwC5JH6n8r3rUNZ/ntchzRTmr/xdOqei3HYY+epX9gI5UMMK2USG c8cydQvQNrSwOBIvhiHivm0lT1vQHaAZ5KJNmU3m64J3l71D8lBM1NQtcK06WlWUOKyH7odHfbZ sADz23UCBCfjubHFx9hnKkGLtnIctJKFXXxpI1pbP36NtEB0Yt5TZO2kbwZ/KZ2b77WUj9VoPOP DgsW+4SAiBCmkRkLWbBIzs4EVmCpFMc0xHzHtFIb4dcbZty8AWyr9DM1UA3N3GpFWj2DkEDOtWF B/t2sFkwTjxvNGKnEQ0kZVtNXbw2MCOC7LnZop2qznLPqHsTOKg6b8bcE2HqOMYevX7N4MH+vDa BvFD5jxQMkO3uTM0S6rqONvUoUkOeT8W4NnHjVcbRNa1UxUGbIYyV1uysayA= X-Received: by 2002:a17:903:a8f:b0:2aa:e3d1:1430 with SMTP id d9443c01a7336-2adf7943a52mr17975725ad.23.1772086450448; Wed, 25 Feb 2026 22:14:10 -0800 (PST) X-Received: by 2002:a17:903:a8f:b0:2aa:e3d1:1430 with SMTP id d9443c01a7336-2adf7943a52mr17975445ad.23.1772086449916; Wed, 25 Feb 2026 22:14:09 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69fa43sm11406555ad.46.2026.02.25.22.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 22:14:09 -0800 (PST) Date: Thu, 26 Feb 2026 11:44:02 +0530 From: Abhinaba Rakshit To: Krzysztof Kozlowski Cc: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v6 3/4] ufs: host: Add ICE clock scaling during UFS clock changes Message-ID: References: <20260219-enable-ufs-ice-clock-scaling-v6-0-0c5245117d45@oss.qualcomm.com> <20260219-enable-ufs-ice-clock-scaling-v6-3-0c5245117d45@oss.qualcomm.com> <784d5711-3f3a-48af-ab1b-9a8834249445@kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <784d5711-3f3a-48af-ab1b-9a8834249445@kernel.org> X-Proofpoint-ORIG-GUID: 4Vom4usRRQBss9OotXW8eayVhsA-SEG9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI2MDA1MiBTYWx0ZWRfX0pWZY0ENyw2e r1jw+42uZYKzqs+OBhODW+P3sOYUPNi4eZ0R6fRF3JEI+RZzV0ZkQUbVp7S5hRM90LjMEpySGAJ Y4bvXhVz535UDWFrfcvutJnbOSZM840fSYE34x9vewl+QqamnJkiopJqeUayUiMDp7b/LY1AmLA HQ8tZwNpTk1Fm0Pt+awYNGjgWm1AgcboWpPRwdBFM4qij4YtMPrLWv0sDM5+dixJsZ6Ao4ejXon gzAM3gtRysjUk4SSp9UXXbbYi2XM6ccQcSqCn6ehrNzlMSb7brbCgNcylJioVNGAyLT4D97dPay zWUvvS8k29/WGEpYSdvnrq6VVHHSuwz2M7QDLTvJd5pwgFYALQi3weKL0nMxOIADkD/dWWJ45eu H4fb7ALlnIT4PI2motlVmejHkqM7fCJyKhUmZ7n1DC76QVMLRGHKTHshD1WomjO7YsLANlN3dSy UNApJfvZslQ/By9Wyow== X-Authority-Analysis: v=2.4 cv=NJLYOk6g c=1 sm=1 tr=0 ts=699fe4b3 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vLMaN86HkaFgGR5djpcA:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: 4Vom4usRRQBss9OotXW8eayVhsA-SEG9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_04,2026-02-25_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602260052 On Wed, Feb 25, 2026 at 03:12:18PM +0100, Krzysztof Kozlowski wrote: > On 25/02/2026 13:58, Abhinaba Rakshit wrote: > > On Wed, Feb 25, 2026 at 10:00:12AM +0100, Krzysztof Kozlowski wrote: > >> On 19/02/2026 10:39, Abhinaba Rakshit wrote: > >>> Implement ICE (Inline Crypto Engine) clock scaling in sync with > >>> UFS controller clock scaling. This ensures that the ICE operates at > >>> an appropriate frequency when the UFS clocks are scaled up or down, > >>> improving performance and maintaining stability for crypto operations. > >>> > >>> Incase of OPP scaling is not supported by ICE, ensure to not prevent > >>> devfreq for UFS, as ICE OPP-table is optional. > >>> > >>> Acked-by: Manivannan Sadhasivam > >>> Signed-off-by: Abhinaba Rakshit > >>> --- > >>> drivers/ufs/host/ufs-qcom.c | 21 ++++++++++++++++++++- > >> > >> > >> SCSI/UFS is not respecting subsystem boundaries, thus you must not > >> combine multiple subsystem when targeting UFS. > >> > >> Please split your patches. > > > > Sorry, if I fail to understand the context here. > > This patch-series is already split into 4 patches based on the subsystem. > > s/patches/patchset/ > Please split the patchset to not combine independent patches targeting > different subsystem into one patchset. In this series, the UFS subsystem patch depends on the new ICE clock-scaling API introduced in the crypto/ICE patch. Without that ICE change, the UFS driver cannot call the scaling helper, so the UFS subsystem patch cannot be applied *independently*. Given this dependency, splitting the series into separate, standalone patchsets would break bisectability and lead to build/runtime failures if they are not merged together. Please let me know what is the preferred approach in such instance. Abhinaba Rakshit