From: Dan Carpenter <dan.carpenter@linaro.org>
To: Karan Tilak Kumar <kartilak@cisco.com>
Cc: sebaddel@cisco.com, arulponn@cisco.com, djhawar@cisco.com,
gcboffa@cisco.com, aeasi@cisco.com, mkai2@cisco.com,
satishkh@cisco.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, jmeneghi@redhat.com,
revers@redhat.com, Hannes Reinecke <hare@kernel.org>,
Lee Duncan <lduncan@suse.com>
Subject: Re: [PATCH 2/5] scsi: fnic: Do not use GFP_ZERO for mempools
Date: Thu, 19 Feb 2026 09:06:21 +0300 [thread overview]
Message-ID: <aZaoXRkzyCsGm9n7@stanley.mountain> (raw)
In-Reply-To: <20260217223943.7938-2-kartilak@cisco.com>
On Tue, Feb 17, 2026 at 02:39:40PM -0800, Karan Tilak Kumar wrote:
> One cannot use the GFP_ZERO flag for mempool allocation, so use
> memset() instead.
>
This kind of thing could easily translate into a static checker rule.
KTODO: make a static checker rule to not pass GFP_ZERO to mempool_alloc()
regards,
dan carpenter
next prev parent reply other threads:[~2026-02-19 6:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 22:39 [PATCH 1/5] scsi: fnic: Use mempool for receive frames Karan Tilak Kumar
2026-02-17 22:39 ` [PATCH 2/5] scsi: fnic: Do not use GFP_ZERO for mempools Karan Tilak Kumar
2026-02-19 6:06 ` Dan Carpenter [this message]
2026-02-19 19:30 ` Karan Tilak Kumar (kartilak)
2026-02-17 22:39 ` [PATCH 3/5] scsi: fnic: Rename fnic_scsi_fcpio_reset() Karan Tilak Kumar
2026-02-17 22:39 ` [PATCH 4/5] scsi: fnic: Refactor in_remove flag and call to fnic_fcpio_reset() Karan Tilak Kumar
2026-02-17 22:39 ` [PATCH 5/5] scsi: fnic: Bump up version number Karan Tilak Kumar
2026-02-24 19:13 ` [PATCH 1/5] scsi: fnic: Use mempool for receive frames Martin K. Petersen
2026-02-28 22:22 ` Martin K. Petersen
2026-03-01 2:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZaoXRkzyCsGm9n7@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=aeasi@cisco.com \
--cc=arulponn@cisco.com \
--cc=djhawar@cisco.com \
--cc=gcboffa@cisco.com \
--cc=hare@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jmeneghi@redhat.com \
--cc=kartilak@cisco.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mkai2@cisco.com \
--cc=revers@redhat.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox