From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0F7727AC4C for ; Sat, 14 Mar 2026 04:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773462931; cv=none; b=PRdDVXgb2kPRvR5+FurRR6fFuU+i30fuQwuuIaPjJ/s67CbvMO28m8b0qvg+5QmJAuoEP/I74X26zma5eqEueKHtbjoOHfgtiYbASfctkjRjWf56ntzTEEm7FA1AFA9yNyq95OJ8hoq9wi2DMH0kEejxNi+bDu3bxUmTUfsq4M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773462931; c=relaxed/simple; bh=7omqseBT54QiYBxNVl0EH3Wq2KJNliWq9MpDh7Ug7WY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IFYE+sjK6YMYDqtEBkH7/huZSaoyXDZAhjZ8kGwo6MQ3fx9kxGVao+JKOoUjDLXJAKy6EMI9tITx0U44RrzHfI81Xktsp9f6nOF9CxZ3a3l7jvihj+EF35ZebHwsb47fg05uST2iDiy8aRZgAGxVvPCv1ON/WLngG5iTOLBbQ38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Cwvnt4dT; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Cwvnt4dT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773462929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oFCE0765f92uX2IgFFqUbjXSAd+HWvC6aFzPdbzLksw=; b=Cwvnt4dTGT+fk56sKdmXjk8agSDQP+i1Qyta21Tfq/vnYTa/8vZYx5iBYCA9DhxZAvBIWh 5filmKJAzCyX1jIMku6/cm3UHf8MxaTGrs+Dgmv3eyykhTD514DWuebf3ZPeL5o8ARt+fE zoPJkOB0gUpIXfxzkQ7Ardt+BJ0XvY0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-kJ0wgQkvP5KS8aaMfu1ItQ-1; Sat, 14 Mar 2026 00:35:25 -0400 X-MC-Unique: kJ0wgQkvP5KS8aaMfu1ItQ-1 X-Mimecast-MFC-AGG-ID: kJ0wgQkvP5KS8aaMfu1ItQ_1773462923 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 77E881953987; Sat, 14 Mar 2026 04:35:22 +0000 (UTC) Received: from bmarzins-01.fast.eng.rdu2.dc.redhat.com (bmarzins-01.fast.eng.rdu2.dc.redhat.com [10.6.23.12]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F019119560B7; Sat, 14 Mar 2026 04:35:19 +0000 (UTC) Received: from bmarzins-01.fast.eng.rdu2.dc.redhat.com (localhost [127.0.0.1]) by bmarzins-01.fast.eng.rdu2.dc.redhat.com (8.18.1/8.17.1) with ESMTPS id 62E4ZI4W688154 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 14 Mar 2026 00:35:18 -0400 Received: (from bmarzins@localhost) by bmarzins-01.fast.eng.rdu2.dc.redhat.com (8.18.1/8.18.1/Submit) id 62E4ZGme688153; Sat, 14 Mar 2026 00:35:16 -0400 Date: Sat, 14 Mar 2026 00:35:16 -0400 From: Benjamin Marzinski To: John Garry Cc: hch@lst.de, kbusch@kernel.org, martin.petersen@oracle.com, james.bottomley@hansenpartnership.com, hare@suse.com, jmeneghi@redhat.com, linux-nvme@lists.infradead.org, sagi@grimberg.me, axboe@fb.com, linux-scsi@vger.kernel.org, michael.christie@oracle.com, snitzer@kernel.org, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, nilay@linux.ibm.com Subject: Re: [PATCH 4/8] scsi: Create a core ALUA driver Message-ID: References: <20260310114925.1222263-1-john.g.garry@oracle.com> <20260310114925.1222263-5-john.g.garry@oracle.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310114925.1222263-5-john.g.garry@oracle.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Tue, Mar 10, 2026 at 11:49:21AM +0000, John Garry wrote: > Add a dedicated ALUA driver which can be used for native SCSI multipath > and also DH-based ALUA support. > > Only core functions to submit a RTPG, STPG, tur, and also helper functions > are added. > > The code from scsi_dh_alua.c to maintain the port groups is not added, > because it is quite intertwined with the DH code. However the port group > management code would be quite useful. > > Hannes Reinecke originally authored this code. > > Signed-off-by: John Garry > diff --git a/drivers/scsi/scsi_alua.c b/drivers/scsi/scsi_alua.c > new file mode 100644 > index 0000000000000..2e4102192dcb9 > --- /dev/null > +++ b/drivers/scsi/scsi_alua.c > @@ -0,0 +1,204 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Generic SCSI-3 ALUA SCSI driver > + * > + * Copyright (C) 2007-2010 Hannes Reinecke, SUSE Linux Products GmbH. > + * All rights reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#define DRV_NAME "alua" > + > +#define ALUA_FAILOVER_RETRIES 5 > + > +/* > + * alua_check_tpgs - Evaluate TPGS setting > + * @sdev: device to be checked > + * > + * Examine the TPGS setting of the sdev to find out if ALUA > + * is supported. > + */ > +int alua_check_tpgs(struct scsi_device *sdev) > +{ > + int tpgs = TPGS_MODE_NONE; > + > + /* > + * ALUA support for non-disk devices is fraught with > + * difficulties, so disable it for now. > + */ > + if (sdev->type != TYPE_DISK) { > + sdev_printk(KERN_INFO, sdev, > + "%s: disable for non-disk devices\n", > + DRV_NAME); > + return tpgs; > + } > + > + tpgs = scsi_device_tpgs(sdev); > + switch (tpgs) { > + case TPGS_MODE_EXPLICIT|TPGS_MODE_IMPLICIT: > + sdev_printk(KERN_INFO, sdev, > + "%s: supports implicit and explicit TPGS\n", > + DRV_NAME); > + break; > + case TPGS_MODE_EXPLICIT: > + sdev_printk(KERN_INFO, sdev, "%s: supports explicit TPGS\n", > + DRV_NAME); > + break; > + case TPGS_MODE_IMPLICIT: > + sdev_printk(KERN_INFO, sdev, "%s: supports implicit TPGS\n", > + DRV_NAME); > + break; > + case TPGS_MODE_NONE: > + sdev_printk(KERN_INFO, sdev, "%s: not supported\n", > + DRV_NAME); > + break; > + default: > + sdev_printk(KERN_INFO, sdev, > + "%s: unsupported TPGS setting %d\n", > + DRV_NAME, tpgs); > + tpgs = TPGS_MODE_NONE; > + break; > + } > + > + return tpgs; > +} > +EXPORT_SYMBOL_GPL(alua_check_tpgs); > + > +/* > + * alua_tur - Send a TEST UNIT READY > + * @sdev: device to which the TEST UNIT READY command should be send > + * > + * Send a TEST UNIT READY to @sdev to figure out the device state > + * Returns SCSI_DH_RETRY if the sense code is NOT READY/ALUA TRANSITIONING, > + * 0 if no error occurred, and SCSI_DH_IO otherwise. Nitpick: The comment here still references SCSI_DH_ values -Ben > + */ > +int alua_tur(struct scsi_device *sdev)