From: Shivasharan Srikanteshwara <shivasharan.srikanteshwara@broadcom.com>
To: Sumit Saxena <sumit.saxena@broadcom.com>,
Kees Cook <keescook@chromium.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Kashyap Desai <kashyap.desai@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"PDL,MEGARAIDLINUX" <megaraidlinux.pdl@broadcom.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] scsi: megaraid: Convert timers to use timer_setup()
Date: Wed, 8 Nov 2017 21:46:31 +0530 [thread overview]
Message-ID: <ac132cbd804bec5892ad38de3afe6a9b@mail.gmail.com> (raw)
In-Reply-To: <92b3d37d10162a899d5a829351fd1512@mail.gmail.com>
> -----Original Message-----
> From: Sumit Saxena [mailto:sumit.saxena@broadcom.com]
> Sent: Wednesday, November 1, 2017 12:18 AM
> To: Kees Cook; Martin K. Petersen
> Cc: Kashyap Desai; Shivasharan Srikanteshwara; James E.J. Bottomley;
> PDL,MEGARAIDLINUX; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH] scsi: megaraid: Convert timers to use timer_setup()
>
> -----Original Message-----
> From: Kees Cook [mailto:keescook@chromium.org]
> Sent: Wednesday, October 25, 2017 3:37 PM
> To: Martin K. Petersen
> Cc: Kashyap Desai; Sumit Saxena; Shivasharan S; James E.J. Bottomley;
> megaraidlinux.pdl@broadcom.com; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] scsi: megaraid: Convert timers to use timer_setup()
>
> In preparation for unconditionally passing the struct timer_list pointer
> to all
> timer callbacks, switch to using the new timer_setup() and
> from_timer() to pass the timer pointer explicitly. Also consolidates the
> timer
> setup functions arguments, which are all identical, and corrects on-stack
> timer
> usage.
>
Ran basic sanity test for megaraid_sas part, and the changes look good.
Acked-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Tested-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Hannes,
Can you please take a look at the megaraid_mbox and megaraid_mm changes?
Thanks,
Shivasharan
prev parent reply other threads:[~2017-11-08 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 10:07 [PATCH] scsi: megaraid: Convert timers to use timer_setup() Kees Cook
2017-10-31 15:45 ` Martin K. Petersen
2017-10-31 18:47 ` Sumit Saxena
2017-11-08 16:16 ` Shivasharan Srikanteshwara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac132cbd804bec5892ad38de3afe6a9b@mail.gmail.com \
--to=shivasharan.srikanteshwara@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).