From: John Garry <john.g.garry@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>,
yebin <yebin@huaweicloud.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: zhangxiaoxu5@huawei.com
Subject: Re: [PATCH v3] scsi: core: clear driver private data when retry request
Date: Wed, 19 Feb 2025 14:13:50 +0000 [thread overview]
Message-ID: <ad661773-2ef5-481b-aa35-45b83e4f4a8d@oracle.com> (raw)
In-Reply-To: <3dd1baa8-e236-41f2-810b-e14a28b72ba5@acm.org>
On 18/02/2025 18:10, Bart Van Assche wrote:
> On 2/18/25 4:13 AM, John Garry wrote:
>> TBH, I am not sure on the history here. Maybe Bart or Christoph knows,
>> but my impression is still that the priv data is only cleared once in
>> the lifetime of the request (from 1bad6c4a) - at prep time - and some
>> drivers may rely on that (not be cleared again). Unlikely, though.
>
> I'm not aware of any such drivers.
>
> Driver-private data was introduced together with the scsi-mq code. I'm
> not aware of a similar concept in the legacy SCSI core.
ok, fine. Indeed, to me, it does not make much sense to keep the data in
this structure persistent between retries anyway.
Thanks,
John
next prev parent reply other threads:[~2025-02-19 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 2:16 [PATCH v3] scsi: core: clear driver private data when retry request Ye Bin
2025-02-17 9:44 ` John Garry
2025-02-18 11:23 ` yebin
2025-02-18 12:13 ` John Garry
2025-02-18 18:10 ` Bart Van Assche
2025-02-19 14:13 ` John Garry [this message]
2025-02-19 20:31 ` Bart Van Assche
2025-02-21 3:27 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad661773-2ef5-481b-aa35-45b83e4f4a8d@oracle.com \
--to=john.g.garry@oracle.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yebin@huaweicloud.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox