public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.com>
To: Don Brace <don.brace@microsemi.com>,
	Hannes Reinecke <hare@suse.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCHv2] hpsa: expose enclosures
Date: Tue, 7 Mar 2017 16:24:45 +0100	[thread overview]
Message-ID: <af59c314-358c-0dba-722f-c582eabf1092@suse.com> (raw)
In-Reply-To: <4993A297653ECB4581FA5C3C31323D194F331B4F@avsrvexchmbx1.microsemi.net>

On 03/07/2017 04:05 PM, Don Brace wrote:
>> -----Original Message-----
>> From: Hannes Reinecke [mailto:hare@suse.de]
>> Sent: Thursday, February 23, 2017 4:55 AM
>> To: Martin K. Petersen <martin.petersen@oracle.com>
>> Cc: Christoph Hellwig <hch@lst.de>; James Bottomley
>> <james.bottomley@hansenpartnership.com>; linux-scsi@vger.kernel.org;
>> Hannes Reinecke <hare@suse.de>; Don Brace
>> <don.brace@microsemi.com>; Hannes Reinecke <hare@suse.com>
>> Subject: [PATCHv2] hpsa: expose enclosures
>>
>> EXTERNAL EMAIL
>>
>>
>> Some servers have a built-in enclosure which will show up on the
>> same bus as the internal physical devices. This patch fixes the
>> driver to expose them.
>>
>> Cc: Don Brace <don.brace@microsemi.com>
>> Signed-off-by: Hannes Reinecke <hare@suse.com>
> 
> Masking various SES targets is a conscious choice, not a design oversight.
> So, I have to decline this patch.,
> 
Would you be okay with a module parameter for this?
It really feels stupid to present the user with an enclosure device
during boot (as hpsa presents all physical LUNs during booting), but not
exporting it to the user.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.com			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2017-03-07 15:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 10:55 [PATCHv2] hpsa: expose enclosures Hannes Reinecke
2017-03-07 15:05 ` Don Brace
2017-03-07 15:24   ` Hannes Reinecke [this message]
2017-03-07 16:33     ` Don Brace

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af59c314-358c-0dba-722f-c582eabf1092@suse.com \
    --to=hare@suse.com \
    --cc=don.brace@microsemi.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox