Re: [PATCH v3 3/9] NTB: Remove pci_aer_clear_nonfatal_status() call

Serge Semin
2022-09-28T11:07:22Z

On Wed, Sep 28, 2022 at 06:59:40PM +0800, Zhuo Chen wrote:
> There is no need to clear error status during init code, so remove it.

Why do you think there isn't? Justify in more details.

-Sergey

>
> Signed-off-by: Zhuo Chen <chenzhuo.1@bytedance.com>
> ---
> drivers/ntb/hw/idt/ntb_hw_idt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
> index 0ed6f809ff2e..fed03217289d 100644
> --- a/drivers/ntb/hw/idt/ntb_hw_idt.c
> +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
> @@ -2657,8 +2657,6 @@ static int idt_init_pci(struct idt_ntb_dev *ndev)
> ret = pci_enable_pcie_error_reporting(pdev);
> if (ret != 0)
> dev_warn(&pdev->dev, "PCIe AER capability disabled\n");
> - else /* Cleanup nonfatal error status before getting to init */
> - pci_aer_clear_nonfatal_status(pdev);
>
> /* First enable the PCI device */
> ret = pcim_enable_device(pdev);
> --
> 2.30.1 (Apple Git-130)
>