From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Brace Subject: RE: [PATCH V3 2/2] scsi: hpsa: drop shutdown callback Date: Wed, 30 May 2018 19:25:07 +0000 Message-ID: References: <1527542471-10316-1-git-send-email-okaya@codeaurora.org> <1527542471-10316-2-git-send-email-okaya@codeaurora.org> <51bb7b82-c4a1-435c-7668-639db96d76e1@finnie.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51bb7b82-c4a1-435c-7668-639db96d76e1@finnie.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ryan Finnie , Sinan Kaya , "linux-pci@vger.kernel.org" , "timur@codeaurora.org" Cc: "James E.J. Bottomley" , "open list:HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)" , "Martin K. Petersen" , "linux-arm-msm@vger.kernel.org" , "esc.storagedev" , open list , "stable@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-scsi@vger.kernel.org > -----Original Message----- > From: Ryan Finnie [mailto:ryan@finnie.org] > Sent: Tuesday, May 29, 2018 8:50 PM > To: Sinan Kaya ; linux-pci@vger.kernel.org; > timur@codeaurora.org > Cc: linux-arm-msm@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > stable@vger.kernel.org; Don Brace ; James E.J. > Bottomley ; Martin K. Petersen > ; esc.storagedev > ; open list:HEWLETT-PACKARD SMART ARRAY > RAID DRIVER (hpsa) ; open list kernel@vger.kernel.org> > Subject: Re: [PATCH V3 2/2] scsi: hpsa: drop shutdown callback > > EXTERNAL EMAIL > > > On 05/28/2018 02:21 PM, Sinan Kaya wrote: > > 'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during > > shutdown")' has been added to kernel to shutdown pending PCIe port > > service interrupts during reboot so that a newly started kexec kernel > > wouldn't observe pending interrupts. > > > > pcie_port_device_remove() is disabling the root port and switches by > > calling pci_disable_device() after all PCIe service drivers are shutdown. > > > > This has been found to cause crashes on HP DL360 Gen9 machines during > > reboot due to hpsa driver not clearing the bus master bit during the > > shutdown procedure by calling pci_disable_device(). > > > > Drop the shutdown API and do an orderly clean up by using the remove. > > > > Signed-off-by: Sinan Kaya > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=199779 > > Fixes: cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown") > > Cc: stable@vger.kernel.org > > Reported-by: Ryan Finnie > > Tested successfully on DL360 Gen9 and DL380 Gen9. > > Tested-by: Ryan Finnie The shutdown path issues a cache flush to the controller. Without this flush, you will see "Dirty Cache" messages at POST. It is best to keep the shutdown path. Thanks, Don Brace ESC - Smart Storage Microsemi Corporation