From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFD7448B39B for ; Tue, 9 Jun 2026 15:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781019283; cv=none; b=oZweUMg3JC4L8Jsirwj9NlimPAsngr/EwsVDsbNihKTY3NT1Dr1CHUWGb3cOSXL4RMZ0wGXBnrLwfUnVuz1ROX1IK3/uL7cRSIcF1PtCS7AHUZwe+MkHi1YY/ABGawLrKBr3WduuObKxN0Ne0qikXHaVwtcNMODl00QDXt/3gw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781019283; c=relaxed/simple; bh=5O0JkPvGvNCC2/+/mjU+ydTddQHPWxobpi9WKv/6i2Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VY76PWNBGDzt7tZxiyTXFxNvHOX5w/6a+jUsgbR2GbiWMx4obxeTnQNUdGFSCHfWA+U+GG5eqitDwOLTS6/udoPMlxUdIU8jEEY/FLvRl8SV91MmRBZYP2DhmlQdj05o2YotYri4SpjdGn762Yyu10I/WYgwtZhgiDuZtKmjBt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=gEjGJNSg; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="gEjGJNSg" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-490be03d47bso49318145e9.0 for ; Tue, 09 Jun 2026 08:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781019280; x=1781624080; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=792RkLO86k+ZJOzIRVIVj9y7He3LCXZcsZ9MVtttc9Q=; b=gEjGJNSgeWLe99D4Y9Vg6R0GNWSDA90rUwURgu/jOLbZUy+zenR1BeoViOmA2RXitS EDSEp4tN9kfpVi95RGzjHCogZsS0RgJyBVZdYbMtVjU7DCaWIQdg7qjl40BEcUI7U4tB WEtmy3rO97t5X3HLr/Krqkyai9WdV7qE9IB0zhKXctILfiArG8hEZIn75IoLeD0IvdDC w6o+Zcm8P4qHLqmfcj0WRf1Dv2QZB2T+8gRdmEFGck6ZEKEvVF8oUtjlhytRNi/yg0vd FJ0FP1DAu/L2yc25+8ja0XKUhLUVT+Rff0t3r6lD4KynUgl7eRPqFUHPmgpQE0inwWyd Qfsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781019280; x=1781624080; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=792RkLO86k+ZJOzIRVIVj9y7He3LCXZcsZ9MVtttc9Q=; b=JkqykvDmSIcfsHIu73MVTJp6vxByAo12n9OFiERM6anyDg0OPPgwAl445FmT65XNyZ VblyldsHQy0OzMOZ+iZaj8HyV4GG67gmFhfWEXRq87h1KPc9cjWuMUDaYXxBqs/4qXyU rvCsgUZ8UZ5iRGDBgjgZZkCt8jwGqmFym5puHlj8WA+YacqBcNuDMkWUiLCNwEP5dE8w D7Co7VXlLjyv48qqILEjHzOb+/xp+Xjs2GbT+r2SziIQnU6go+OrSd3SZoefMCctIjrb yjTf7m05H9PmAp+56+NCysiyYhZrBn5fH78HudtaIiRLQ5rfeOH65Z1JgNGlh57Y7gJu ejeA== X-Forwarded-Encrypted: i=1; AFNElJ/RdAaDp/ELyhYiDnw9klAYyn9zyT5I6k9yx/CqXLt5f9Hp8DZbKaAjEMVjMqGlfGrTZWCfvCuArj+N@vger.kernel.org X-Gm-Message-State: AOJu0Yz3sBOhGx3f7dmUoizshCrMDPKbKVAh3Lp+PPRWhyake5Rsy/hw 8VOhcp1u++KUSGsDCXYrcLfGTUJavwOHcR8xmbwluA8pD918MeAt/Na0cCzgPv34JUc= X-Gm-Gg: Acq92OHQi3izYGtXL/6XS5A3gyEGQMMtnuDEzFRHFu4CC/lyZIalF4ecwnK+IasSUlp HBnm6qE7t4uX26jWVyXTiAA+OxNcLT8d+qb9TO4fojvu6In79xfsr0OrOjgH8kGbbmp0dc7tvcY ysjPggPbWGVoNOARXQBfcEwRakWN0KSvLL90Xw6pHRHdcTQ+YyV/9DF0fvNQd8D3IgrqMA3ZgaI q2+GiW6kmi2edsCHHbPB0NOVMjCVW4aNv6VfzrrI7b0MeFHWG0kSKWedN9H3cWSYmLBIH+x4cKU OjXneU6OsNrJifaUvPu5AUW4msF2HCHblf67t0plDmsFVEwAQLSPD7enUuu5D+Mfemuxxyg9gSR ibEA+rOfJUTwobOrDsotSq56KZpZNvTUJc7Yhcj/NhPJ/DBxLU0PomgbHaYyfRBFwaBwZT+Bt95 61+DTJjGvNQQFfPB+9dyvt49H0ZJN2vsK4NHWUHxLDRWUu2naFg9mF1Zalc03mNcSBYAuSTkobC qFurZ6E3XHmfHKOEdn1T1qX5Q== X-Received: by 2002:a05:600c:81c9:b0:490:bd66:db49 with SMTP id 5b1f17b1804b1-490c25a1e20mr289084495e9.12.1781019280238; Tue, 09 Jun 2026 08:34:40 -0700 (PDT) Received: from localhost (p200300f65f47db045b0dbdd314d8a71f.dip0.t-ipconnect.de. [2003:f6:5f47:db04:5b0d:bdd3:14d8:a71f]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-490bc3c183asm494834455e9.6.2026.06.09.08.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 08:34:39 -0700 (PDT) Date: Tue, 9 Jun 2026 17:34:38 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Adam Radford , Adaptec OEM Raid Solutions , Matthew Wilcox , Hannes Reinecke , Finn Thain , Michael Schmitz , Ram Vegesna , Yihang Li , Don Brace , HighPoint Linux Team , Brian King , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , Jack Wang , Junrui Luo , Kees Cook , Dave Jiang , Giovanni Cabiddu , Bjorn Helgaas , Lukas Wunner , Sebastian Andrzej Siewior , Thomas Gleixner , Duoming Zhou , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, storagedev@microchip.com, megaraidlinux.pdl@broadcom.com, Markus Schneider-Pargmann Subject: Re: [PATCH] scsi: Consistently define pci_device_ids using named initializers Message-ID: References: <20260429101820.3059523-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4zu2ga2qgi7ol5sf" Content-Disposition: inline In-Reply-To: <20260429101820.3059523-2-u.kleine-koenig@baylibre.com> --4zu2ga2qgi7ol5sf Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] scsi: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 [Dropping Bradley Grove and Michael Reed from Cc: as their addresses bounced] On Wed, Apr 29, 2026 at 12:18:20PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > ... and PCI device helpers. >=20 > The various struct pci_device_id arrays were initialized mostly by one > of the PCI_DEVICE macros and then list expressions. The latter isn't > easily readable if you're not into PCI. Using named initializers is more > explicit and thus easier to parse. >=20 > Also use PCI_DEVICE* helper macros to assign .vendor, .device, > .subvendor and .subdevice where appropriate and skip explicit > assignments of 0 (which the compiler takes care of). >=20 > The secret plan is to make struct pci_device_id::driver_data an > anonymous union (similar to > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre= =2Ecom/) > and that requires named initializers. But it's also a nice cleanup on > its own. >=20 > This change doesn't introduce changes to the compiled pci_device_id > arrays. Tested on x86 and arm64. >=20 > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > --- > Hello, >=20 > the mentioned follow-up quest allows to do >=20 > - { PCI_VDEVICE(TTI, 0x3220), .driver_data =3D (kernel_ulong_t)&hptiop_i= tl_ops }, > + { PCI_VDEVICE(TTI, 0x3220), .driver_data_ptr =3D &hptiop_itl_ops }, >=20 > which gets rid of a bunch of casts and so brings a little bit more type > safety. This patch is a preparation for that. >=20 > I assume a single patch for all of drivers/scsi is fine. If not I can > split per driver. Is this patch still on someone's radar? Best regards Uwe --4zu2ga2qgi7ol5sf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmooMooACgkQj4D7WH0S /k7rYAf7BB8NfldywKX4tj4A6aBVySOEe2C7pUP1TdlEr3w19ARcaTKXslkG4Ehf 3bsCMPQMhEjQaFnmd8qLPqLJt7H4tBDoXphJO2ydmt4pKJ6GYA+aIZsUPyLhlcYN Jj44sLl6uuougfkZ95xMlkV8BqwoumkQkJXzshYIWXOUTGs474POTHB51QdoEfCX 2I7X6sEy9N7YYtshmD4o40fj3dRxxemVfdbpwWAnAD2p7UK8K/IG1l+IbG3Znp/L 1UFRAw/ukBk7IxkxA/RUDCc7jMor+/X6AkLLF+r3TLvnblpL8CEO2yaXmqNhEiBT vWE5iW6MuwrRCxfKUVsBadNfYqvblQ== =uDdw -----END PGP SIGNATURE----- --4zu2ga2qgi7ol5sf--