Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: "Milan P. Gandhi" <mgandhi@redhat.com>
Cc: kernel-janitors@vger.kernel.org, qla2xxx-upstream@qlogic.com,
	jejb@linux.ibm.com, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: Fix a small typo in qla_bsg.c
Date: Tue, 12 Mar 2019 13:06:09 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1903121305220.4097@hadrien> (raw)
In-Reply-To: <20190312115313.GA12695@machine1>



On Tue, 12 Mar 2019, Milan P. Gandhi wrote:

> This patch fixes a minor formatting issue with comment section and a
> typo for 'iiDMA' cmd in drivers/scsi/qla2xxx/qla_bsg.c

This seems to be two completely unrelated changes.  The subject line
promises only one change, and indeed only one change per patch would have
been better.  You should make a series.

julia

>
> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index 17d42658ad9a..2353be988907 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -1,4 +1,4 @@
> -	/*
> +/*
>   * QLogic Fibre Channel HBA Driver
>   * Copyright (c)  2003-2014 QLogic Corporation
>   *
> @@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
>
>  	if (rval) {
>  		ql_log(ql_log_warn, vha, 0x704c,
> -		    "iIDMA cmd failed for %8phN -- "
> +		    "iiDMA cmd failed for %8phN -- "
>  		    "%04x %x %04x %04x.\n", fcport->port_name,
>  		    rval, fcport->fp_speed, mb[0], mb[1]);
>  		rval = (DID_ERROR << 16);
>

      reply	other threads:[~2019-03-12 12:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 11:53 [PATCH] scsi: qla2xxx: Fix a small typo in qla_bsg.c Milan P. Gandhi
2019-03-12 12:06 ` Julia Lawall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1903121305220.4097@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mgandhi@redhat.com \
    --cc=qla2xxx-upstream@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox