From: Linus Torvalds <torvalds@linux-foundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] intermediate SCSI updates
Date: Mon, 13 Oct 2008 10:22:25 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810131017030.3288@nehalem.linux-foundation.org> (raw)
In-Reply-To: <1223909115.5566.13.camel@localhost.localdomain>
On Mon, 13 Oct 2008, James Bottomley wrote:
>
> This represents all the pieces of SCSI which were depending on the
> already merged block tree.
Grr. And it doesn't actually compile.
drivers/scsi/sd.c:579:27: error: macro "sd_dif_op" passed 4 arguments, but takes just 3
drivers/scsi/sd.c: In function ‘sd_prep_fn’:
drivers/scsi/sd.c:578: error: ‘sd_dif_op’ undeclared (first use in this function)
drivers/scsi/sd.c:578: error: (Each undeclared identifier is reported only once
drivers/scsi/sd.c:578: error: for each function it appears in.)
Hmm? Was this testedt AT ALL? It can never compile unless that idiotic
CONFIG_BLK_DEV_INTEGRITY option is set that no sane person would set right
now, and which is even documented to not be enabled by default:
If in doubt, say N.
yet it looks like it has not compiled since a commit that was put in in
the middle of September!
What part of "This is total untested crap" are we missing here?
Yeah, I'm grumpy. I expect to not be fed shit like this. It has apparently
been rebased several times, and all apparently with no testing
what-so-ever!
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-13 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 14:45 [GIT PATCH] intermediate SCSI updates James Bottomley
2008-10-13 17:22 ` Linus Torvalds [this message]
2008-10-13 19:20 ` James Bottomley
2008-10-13 21:22 ` Linus Torvalds
2008-10-13 22:02 ` Paul Mackerras
2008-10-13 22:22 ` Martin K. Petersen
2008-10-13 23:44 ` Stephen Rothwell
2008-10-14 12:49 ` James Bottomley
2008-10-17 15:11 ` [GIT PATCH] intermediate SCSI updates (v2) James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810131017030.3288@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox