public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Mike Anderson <andmike@linux.vnet.ibm.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Alexander Beregalov <a.beregalov@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-next@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	linux-scsi@vger.kernel.org, David Miller <davem@davemloft.net>,
	Jens Axboe <jens.axboe@oracle.com>
Subject: Re: next-20081119: general protection fault: get_next_timer_interrupt()
Date: Mon, 24 Nov 2008 23:33:36 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.0811242327130.3235@localhost.localdomain> (raw)
In-Reply-To: <20081124213517.GA25898@linux.vnet.ibm.com>

On Mon, 24 Nov 2008, Mike Anderson wrote:
> Thomas Gleixner <tglx@linutronix.de> wrote:
> > Yeah, block could it be as well. Jens, Mike ?
> 
> I added a comment to bug 12020 on Thursday about a few other systems that
> where seeing the signature shown in bug 12020. It appeared from debug that
> there where a few paths that where adding timers for requests that where
> not expected.
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=12020
> 
> It would be good to know if the debug patch below effects your problem as while.
> 
> If it does we need to investigated a solution to resolve not adding a
> timer for these requests.

Wrong. 

The problem is not a timer which is armed in the first place.

The problem is an armed timer which is not canceled before the data
structure which contains it is freed.

So not arming the timer will probably prevent this particular scan
problem, but it does not solve the general wreckage of freeing a data
structure with a possibly armed timer in it.

You need to fix the code path which frees the data structure which
contains the timer and cancel the timer _before_ freeing the data
structure.

Thanks,

	tglx

  reply	other threads:[~2008-11-24 22:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a4423d670811190714k13721ae8s125e63d520892440@mail.gmail.com>
     [not found] ` <alpine.LFD.2.00.0811191308030.3119@localhost.localdomain>
2008-11-21 10:50   ` next-20081119: general protection fault: get_next_timer_interrupt() Alexander Beregalov
2008-11-24 17:43     ` Thomas Gleixner
2008-11-24 19:15       ` James Bottomley
2008-11-24 19:31         ` Thomas Gleixner
2008-11-24 21:35           ` Mike Anderson
2008-11-24 22:33             ` Thomas Gleixner [this message]
2008-11-24 23:42               ` malahal
2008-11-25  0:09               ` malahal
2008-11-25  0:57                 ` Stephen Rothwell
2008-11-25  2:08                   ` malahal
2008-11-25  8:51                     ` Jens Axboe
2008-11-25 16:59                       ` malahal
2008-11-25 17:14                         ` Alexander Beregalov
     [not found]                         ` <a4423d670811250914x3a42e56egd1bf06e6229666ba@mail.gmail.com>
2008-11-25 17:43                           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0811242327130.3235@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=a.beregalov@gmail.com \
    --cc=andmike@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox