From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: linux-scsi@vger.kernel.org
Subject: badly-named non-Kconfig variables in drivers/scsi/arm
Date: Sat, 26 Sep 2009 08:08:49 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0909260805460.18872@localhost> (raw)
part of the output from a scanning script of mine that searches for
references to alleged Kconfig variables that don't actually exist:
>>>>> ACORNSCSI_CONSTANTS
drivers/scsi/arm/acornscsi.c:106:#undef CONFIG_ACORNSCSI_CONSTANTS
drivers/scsi/arm/acornscsi.c:414:#ifdef CONFIG_ACORNSCSI_CONSTANTS
drivers/scsi/arm/acornscsi.c:492:#ifdef CONFIG_ACORNSCSI_CONSTANTS
>>>>> SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:70:#undef CONFIG_SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:164:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:1672:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:2827:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:2858:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
the problem is with the "CONFIG_" prefix being used for macro names
that aren't actually Kconfig variables. coding style dictates that
anything that starts with "CONFIG_" should be defined in a Kconfig
file somewhere, so either:
1) those two variables should be defined as such, or
2) they can be renamed (just by dropping the CONFIG_ prefix) so as not
to pollute the Kconfig namespace.
thoughts?
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
reply other threads:[~2009-09-26 12:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0909260805460.18872@localhost \
--to=rpjday@crashcourse.ca \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox