badly-named non-Kconfig variables in drivers/scsi/arm

badly-named non-Kconfig variables in drivers/scsi/arm

[Robert P. J. Day]

  part of the output from a scanning script of mine that searches for
references to alleged Kconfig variables that don't actually exist:

>>>>> ACORNSCSI_CONSTANTS
drivers/scsi/arm/acornscsi.c:106:#undef CONFIG_ACORNSCSI_CONSTANTS
drivers/scsi/arm/acornscsi.c:414:#ifdef CONFIG_ACORNSCSI_CONSTANTS
drivers/scsi/arm/acornscsi.c:492:#ifdef CONFIG_ACORNSCSI_CONSTANTS
>>>>> SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:70:#undef CONFIG_SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:164:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:1672:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:2827:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
drivers/scsi/arm/acornscsi.c:2858:#ifdef CONFIG_SCSI_ACORNSCSI_LINK

  the problem is with the "CONFIG_" prefix being used for macro names
that aren't actually Kconfig variables.  coding style dictates that
anything that starts with "CONFIG_" should be defined in a Kconfig
file somewhere, so either:

1) those two variables should be defined as such, or
2) they can be renamed (just by dropping the CONFIG_ prefix) so as not
to pollute the Kconfig namespace.

  thoughts?

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================