From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines Date: Thu, 18 Oct 2018 10:01:22 +1100 (AEDT) Message-ID: References: <35ac9f31-7068-ab93-4629-363ee0bb4c70@suse.de> <2b48c925-73f0-0ca0-2f3c-3c35d90010ba@suse.de> <20181017080923.GC24540@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20181017080923.GC24540@infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig , Hannes Reinecke Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , Geert Uytterhoeven , linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Wed, 17 Oct 2018, Christoph Hellwig wrote: > > Please leave the possibly unused exports as-is. > I take that to mean "leave the conditional export as-is". Hence, I think v3 (posted on the 16th) should address all of the concerns raised by reviewers... --