From: Finn Thain <fthain@telegraphics.com.au>
To: qiwuchen55@gmail.com
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [PATCH] scsi: core: fix a typo of coding format
Date: Sun, 16 Feb 2020 08:15:04 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.22.394.2002160808490.8@nippy.intranet> (raw)
In-Reply-To: <1581757095-11518-1-git-send-email-qiwuchen55@gmail.com>
On Sat, 15 Feb 2020, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
>
> Fix a typo of coding format.
>
It isn't a 'typo' as it appears to be a deliberate choice.
git grep '^ [a-z_0-9]+:$' -- drivers/scsi/
I can't find anything in Documentation/process that bans indentation of
goto labels. Am I missing something? What do you gain?
If there's nothing in the style guide to mandate churn like this patch,
then we might expect more churn when someone else patches the whitespace
back in (for consistency, taste, fame and fortune, whatever).
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
> ---
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 610ee41..a89cfaf 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1563,7 +1563,7 @@ static int scsi_dispatch_cmd(struct scsi_cmnd *cmd)
> }
>
> return rtn;
> - done:
> +done:
> cmd->scsi_done(cmd);
> return 0;
> }
>
prev parent reply other threads:[~2020-02-15 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 8:58 [PATCH] scsi: core: fix a typo of coding format qiwuchen55
2020-02-15 21:15 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.22.394.2002160808490.8@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=chenqiwu@xiaomi.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=qiwuchen55@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox