From: Keith Busch <keith.busch@intel.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Keith Busch <keith.busch@intel.com>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Ric Wheeler <rwheeler@redhat.com>
Subject: Re: [PATCH] sd: dif sector calculation
Date: Fri, 20 Sep 2013 16:52:06 -0600 (MDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1309201647220.31457@AMR> (raw)
In-Reply-To: <yq1ob7ndt0w.fsf@sermon.lab.mkp.net>
On Fri, 20 Sep 2013, Martin K. Petersen wrote:
>>>>>> "Keith" == Keith Busch <keith.busch@intel.com> writes:
>
> Keith> The ref tag should be the device's physical LBA rather than the
> Keith> 512 byte bio sector.
>
> The bip sector is just a seed value set by the application. It is not
> correct to scale it based on sector size or PI interval.
If I follow the current implementation correctly and have a 4k physical
block size, a two block write at LBA 0 will generate ref tags 0 and 1
for that operation. If I read back one block at LBA 1, the current code
will expect the ref tag to be 8, but come back as 1, failing the compare.
prev parent reply other threads:[~2013-09-20 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 3:32 [PATCH] sd: dif sector calculation Keith Busch
2013-09-20 22:31 ` Martin K. Petersen
2013-09-20 22:52 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1309201647220.31457@AMR \
--to=keith.busch@intel.com \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rwheeler@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox