Re: [PATCH] qla2xxx: Resolved a performance issue in interrupt handler

Matthew Wilcox
2009-06-09T21:47:57Z

On Tue, Jun 09, 2009 at 02:46:12PM -0700, Anirban Chakraborty wrote:
>
> On Jun 9, 2009, at 2:43 PM, Matthew Wilcox wrote:
>> While I don't think Doug has MSI-X adapters, a complete patch would
>> change
>> all request_irq() calls to use IRQF_DISABLED, right?
>
> The above patch takes care of replacing all the IRQF_SHARED flags in irq
> registrations with IRQF_DISABLED.

Yes ... but even for the MSI-X case, you want the handler to be run with
interrupts disabled, don't you? If not, why not?

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."